Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339635

Summary:

More options in search page should be expanded when any of its fields are not empty

Product:

z_Archived

Reporter:

Sam Davis <sam.davis>

Component:

Mylyn

Assignee:

Frank Becker <eclipse>

Status:

RESOLVED FIXED

QA Contact:

Frank Becker <eclipse>

Severity:

normal

Priority:

CC:

steffen.pingel

Version:

unspecified

Target Milestone:

3.5

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
patch V1	none
mylyn/context/zip	none
backported patch	none

Description Sam Davis

2011-03-11 00:16:14 EST

More options in search page should be expanded when any of its fields are not empty. I had a keyword set but didn't know it because the section did not expand.

Comment 1 Sam Davis

2011-03-11 00:16:52 EST

The boolean charts section was expanded instead, even though I had not set anything there.

Comment 2 Steffen Pingel

2011-03-11 00:41:43 EST

I have seen this happening occasionally as well. Frank if you have a simple fix we could consider it for 3.5 otherwise we should take a pass through that for 3.6.

Comment 3 Sam Davis

2011-03-11 00:56:37 EST

I can reproduce it consistently:

# do a search with a keyword set
# reopen the search page
# more options is not expanded, but the keyword is still set.

Comment 4 Frank Becker

2011-03-12 08:34:37 EST

Created attachment 191046 [details]
patch V1

Here is what I commit to HEAD.

Steffen, if it is not to late we can include ths in 3.5

Comment 5 Frank Becker

2011-03-12 08:34:40 EST

Created attachment 191047 [details]
mylyn/context/zip

Comment 6 Steffen Pingel

2011-03-12 14:42:31 EST

Thanks. I'll apply the patch for 3.5.

Comment 7 Steffen Pingel

2011-03-12 15:38:16 EST

Created attachment 191055 [details]
backported patch

Comment 8 Steffen Pingel

2011-03-12 16:11:14 EST

Patch committed to e_3_7_m_3_5_x branch.