Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339592

Summary:

[client] get rid of soria dojo theme

Product:

[ECD] Orion

Reporter:

Susan McCourt <susan>

Component:

Client

Assignee:

Susan McCourt <susan>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

aniefer, malgorzata.tomczyk

Version:

0.2

Target Milestone:

0.2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
"nihilo" in the header	none

Description Susan McCourt

2011-03-10 15:42:05 EST

for M6 I restyled selective parts of dojo to get rid of the soria blue.  We should punt the soria style completely and see what "unthemed" styles look like.  Then we could selectively add styling that matches our skinning rather than overriding all that soria blue.

Comment 1 Susan McCourt

2011-03-22 13:09:07 EDT

I tried running without a dojo theme.  It doesn't work because you end up with widgets that have no borders and no uniform spacing.  So we do need to pick a theme.  After running the theme tester, I decided that "nihilo" seems the most neutral.  We still need to override some theme settings for things like:
- custom splitter
- menus whose backgrounds match our colors
- custom hover colors, etc.

Comment 2 Susan McCourt

2011-03-22 13:13:27 EDT

fixed.
There is still some style tweaking to do (in places where we had the blue before, we might have some less than optimal styling, such as grid headings, etc.)

Andrew - since we are changing which dojo stylesheets are being used, do we need to change anything about the built dojo?

Comment 3 Andrew Niefer

2011-03-22 13:18:12 EDT

Our built dojo layer is only javascript, I don't think we need to do anything there to switch the css being used

Comment 4 Malgorzata Janczarska

2011-03-23 05:22:50 EDT

Created attachment 191734 [details]
"nihilo" in the header

I don't know where it came from, but in git-log.html I'm getting the sign "nihilo" on the top. Isn't  "nihilo", the name of the new class?

Comment 5 Susan McCourt

2011-03-23 12:57:58 EDT

(In reply to comment #4)
> Created attachment 191734 [details]
> "nihilo" in the header
> 
> I don't know where it came from, but in git-log.html I'm getting the sign
> "nihilo" on the top. Isn't  "nihilo", the name of the new class?

sorry about that.  I must have had an errant paste when I was manually checking the changes.  Fixed.