Bugzilla – Full Text Bug Listing
| Summary: | Need logic to build the TCF agent as a VxWorks component | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] TCF | Reporter: | Peder Andersen <Peder.Andersen> | ||||||||
| Component: | Agent | Assignee: | Project Inbox <tcf.agent-inbox> | ||||||||
| Status: | RESOLVED NOT_ECLIPSE | QA Contact: | |||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | eugene | ||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 190926 [details]
2 - static task instantiation
This attached patch further improves the Vx support by statically declaring storage for TCF's tasks.
Legal Message: I, Peder Andersen, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL and EDL. I am authorized by my employer, Wind River, to make this
contribution under the EPL and EDL.
Created attachment 190935 [details]
1 - proposed changes
An updated version of the original patch: a more complete conversion from version 0.1 to version 0.3.
Legal Message: I, Peder Andersen, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL and EDL. I am authorized by my employer, Wind River, to make this
contribution under the EPL and EDL.
Most of the files in the patch appears to be very specific for Wind River VxWorks build system. Is there a good reason to put them into the agent source directory? In fact, one of file names in the patch points somewhere outside TCF repository: .../osconfig/vxworks/cdf/01comp_tcfagent.cdf I think theses files don't belong to TCF repository and need to be kept somewhere else. I believe we agreed that VxWorks specific file should not be kept in the TCF repository. The only other change in the patches is changing event_thread variable from static to extern. I suggest creating a separate Bugzilla for that. Also, changing the variable to be extern is rather dirty approach, we need to consider something more elegant. Changing status to NOT_ECLIPSE. (In reply to comment #4) > The only other change in the patches is changing event_thread variable from > static to extern. I suggest creating a separate Bugzilla for that. Submitted bug 344514 for this issue. > Also, > changing the variable to be extern is rather dirty approach, we need to > consider something more elegant. Agreed, the attached changes around the event_thread were just meant to illustrate the problem. |
Created attachment 190922 [details] Proposed changes The attached changeset adds the make/configuration rules necessary to build the TCF agent sources as part of a Wind River component. Includes the "do_install.sh" script used to install a checked-out source tree as a component, which is useful for developing with TCF but may not be desirable in the upstream repository. This also adds a method for registering arbitrary services with the VxWorks agent, similar to the plugin capability offered on other platforms. The first problem is that the external service lacks a way of getting a handle to the agent's Protocol object. Adding the tcf_init_service() routine solves this, but there may be other (concurrency, etc.) issues we will need to tackle as well. Legal Message: I, Peder Andersen, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL and EDL. I am authorized by my employer, Wind River, to make this contribution under the EPL and EDL.