Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339580

Summary: The config.h header creates conflicts with external builds
Product: [Tools] TCF Reporter: Peder Andersen <Peder.Andersen>
Component: AgentAssignee: Project Inbox <tcf.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cdtdoug, eugene
Version: unspecified   
Target Milestone: 1.0.0   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Proposed fix
eugene: iplog-
further improvements eugene: iplog+

Description Peder Andersen CLA 2011-03-10 14:34:13 EST 
Build Identifier: 

The <config.h> header conflicts with headers expected by external build systems, e.g., VxWorks' vxprj.  Since this is such a general name to use in the global header namespace, it should really be either protected under a tcf/ path, or changed to otherwise denote it's TCF's configuration header.

Note: it may be better to take a broader approach and reparent all
globally-visible headers under a single unique pathname (e.g., "tcf/").

Reproducible: Always
Comment 1 Peder Andersen CLA 2011-03-10 14:35:44 EST 
Created attachment 190907 [details]
Proposed fix

Legal Message: I, Peder Andersen, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL and EDL. I am authorized by my employer, Wind River, to make this
contribution under the EPL and EDL.
Comment 2 Peder Andersen CLA 2011-03-10 18:32:09 EST 
Created attachment 190940 [details]
further improvements

Here's one other small change which improves the portability of the TCF agent build.

Legal Message: I, Peder Andersen, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL and EDL. I am authorized by my employer, Wind River, to make this
contribution under the EPL and EDL.
Comment 3 Doug Schaefer CLA 2011-03-11 09:57:10 EST 
Peder, you work under the supervision of co-workers who are committers. No need for the legal disclaimer. It's already assumed.
Comment 4 Eugene Tarassov CLA 2011-04-29 15:43:33 EDT 
Renaming the header file like this would break compilation for all downstream projects. We need to find a less disturbing way to address the issue.
Comment 5 Eugene Tarassov CLA 2011-12-15 17:28:57 EST 
This issue has been resolved in TCF version 1.0.
All header file names now start with "tcf", e.g.:
#include <tcf/config.h>