Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339573

Summary: Splitting the shared area with a part doesn't remove stale placeholders
Product: [Eclipse Project] e4 Reporter: Eric Moffatt <emoffatt>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 4.1 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch to remove *all* stale placeholders whenever anything gets added to the shared area none

Description Eric Moffatt CLA 2011-03-10 14:11:44 EST 
The current code only looks for the addition of an MPlaceholder in the shared area as the hint to remove locals. When you split the area the element that gets added is the new MPartSashContainer...
Comment 1 Eric Moffatt CLA 2011-03-10 14:16:14 EST 
Created attachment 190901 [details]
Patch to remove *all* stale placeholders whenever anything gets added to the shared area


While this appears to be computationally expensive the overall cost is quite low because the number of elements involved isn't very large.

For example a presentation with 10 perspectives open each with 20 views only amounts to 200 tests...
Comment 2 Eric Moffatt CLA 2011-03-10 14:17:11 EST 
Committed in >20110310. Applied the patch.
Comment 3 Eric Moffatt CLA 2011-03-10 14:17:34 EST 
Setting milestone, will verify tomorrow...