Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339458

Summary: Support on Symfoware database
Product: z_Archived Reporter: Abdullah Noman <abdullahn>
Component: EclipselinkAssignee: Nobody - feel free to take it <nobody>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: dieskun, eclipselink.orm-inbox, masumii, tom.ware
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: submitted_patch
Attachments:
Description Flags
Patch for Symfoware database support
none
Updated patch for Symfoware database support
tom.ware: iplog+
Updated Patch after review none

Description Abdullah Noman CLA 2011-03-09 23:08:02 EST 
Hi

For the past year or so we have been running the RT tests against Symfoware database. We have passed all the tests and would like to submit a patch for your review, with the enhancements for Symfoware database support.
The changes we made were:
1. Support setFirstResult()/setMaxResults() in JPA
2. Support creation/deletion of Index
3. Support CascadeOnDelete function
4. Support HistoryPolicy function
4. Fix not to call setAutoCommit(false) during transaction
6. Fix testsets to avoid an exclusive lock problem of tables
7. Fix a simple bug of a SimpleSerializeFetchGroupTests testset
8. Fix a problem using the keyword COUNT
9. Skip unsupported functions by Symfoware

Regards
Noman

Fujitsu Australia Software Technology
Comment 1 Abdullah Noman CLA 2011-03-09 23:13:33 EST 
Created attachment 190814 [details]
Patch for Symfoware database support
Comment 2 Tom Ware CLA 2011-03-18 09:44:53 EDT 
Assigning to myself.  Hopefully I can start to look at these changes in the next 2 weeks.
Comment 3 Dies Koper CLA 2011-03-28 01:53:48 EDT 
CC'ing myself.
Comment 4 Masumi Ito CLA 2011-04-15 05:26:55 EDT 
Hi

We have updated our patch for Symfoware database support.
About changes included in this patch, please see the list which Noman provided in this bug report.
The difference between this patch and the previous patch is:
 1. Added comments
 2. Improved the index support function by reusing exsiting sources
 3. Improved some testcases which we had changed in the previous patch

Regards,
Masumi
Comment 5 Masumi Ito CLA 2011-04-15 05:31:17 EDT 
Created attachment 193336 [details]
Updated patch for Symfoware database support
Comment 6 Tom Ware CLA 2011-04-25 11:27:54 EDT 
Appoligies for not having looked at this yet.  Other commitments are still getting in the way.  I am hoping to look at this soon, but cannot currently give a date.
Comment 7 Tom Ware CLA 2011-05-31 12:56:32 EDT 
Created attachment 197003 [details]
Updated Patch after review

Attaching an updated patch.  Changes have been made to handling of cascaded deletes and some database platform methods.
Comment 8 Tom Ware CLA 2011-05-31 13:22:59 EDT 
- Testing changes to accommodate skipping tests and table recreation differences on Symfoware
- More index support moved to DatabasePlatform, support added on Symfoware
- Bug fixe for firstResult/maxResultss
- cascade deletes changes for platforms that do not support cascade delete on constraints
- some DatabasePlatform API updates

Reviewed by Andrei Ilitchev/Tom Ware -> reviewed user-submitted patch

Testing: JPA LRG has been run on Oracle and MySQL, Core LRG has been run. Symfoware testing will be run by contributers
Comment 9 Tom Ware CLA 2011-05-31 13:24:10 EDT 
Abdullah, Dies -> We have made some changes to the way some of the functionality is implemented, but the behavior should be the same.   If you have additional changes we can look at them for 2.3.1
Comment 10 Eclipse Webmaster CLA 2022-06-09 10:20:38 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink