Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339450

Summary:	[client] nav table should cache selections
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2
Target Milestone:	0.2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2011-03-09 19:37:56 EST

from bug 334718:

> We currently don't cache the checkmark selections in the nav table.  Since we
> now want to update the table as the server completes the move/copy operations,
> we need to start keeping the selections.  I think we should only remember the
> ones that are on page (rather than keeping an additive cache that remembers
> everything you've checked as you've drilled up and down the breadcrumb).

This is along the same lines as "remembering expansion state."  We need a cookie so that the selections are remembered as you traverse history.

Comment 1 Susan McCourt

2011-03-09 19:54:41 EST

There's really two levels of cache to consider.

- in memory caching of expansions.  This is the "should invisible things be selected" issue which has been debated widely in eclipse.  The scenario is:
** expand folder
** select item "foo" in folder
** collapse folder
  --> is foo still selected?  for the purposes of selection menu?
** expand folder
  --> is foo still selected?

- what happens when you reload the page.  This is the browser history/reload case and requires a cookie or something like it.

Comment 2 Susan McCourt

2011-04-06 19:19:14 EDT

Fixed.  Selections are now cached in preferences.
The navigator remembers selection state for any previously browsed level in the navigator.  There is no expiration on this state, so once you select something, you'll forever see it in the selected state (unless you explicitly deselect it or delete/rename it).

(In reply to comment #1)
> There's really two levels of cache to consider.
> 
> - in memory caching of expansions.  This is the "should invisible things be
> selected" issue which has been debated widely in eclipse.  The scenario is:
> ** expand folder
> ** select item "foo" in folder
> ** collapse folder
>   --> is foo still selected?  for the purposes of selection menu?

No.  Desktop eclipse doesn't do this either, the selection is only applicable while the node is expanded.
> ** expand folder
>   --> is foo still selected?

No.  Again, this is consistent with desktop trees. 
> 
> - what happens when you reload the page.  This is the browser history/reload
> case and requires a cookie or something like it.

Reload is working, that was the main point of this bug.