Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339414

Summary: HeapWalking manager should support other debug targets that can provide an IJavaDebugTarget adapter
Product: [Eclipse Project] JDT Reporter: Michael Rennie <Michael_Rennie>
Component: DebugAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: lilywang, ndsilva
Version: 3.7   
Target Milestone: 3.7 M7   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 342073    
Attachments:
Description Flags
proposed fix none

Description Michael Rennie CLA 2011-03-09 14:07:52 EST
Created attachment 190782 [details]
proposed fix

Version: 3.7.0
Build id: I20110307-2110 (and all versions since heap-walking was added)

In its current state, the method HeapWalkingManager#supportsHeapWalking only considers if the supplied object is an instance of IJavaDebugTarget. If the given object is not an instance of IJavaDebugTarget we should ask it for an IJavaDebugTarget adapter, allowing other debug targets to take part in heap-walking.
Comment 1 Natasha D'Silva CLA 2011-03-10 18:56:45 EST
Hi Mike,
Im running into some strange errors in my testing - I'm not sure if they're related tp the patch so I'll do some more testing and update next weel.
Comment 2 Natasha D'Silva CLA 2011-03-14 14:56:41 EDT
(In reply to comment #1)
> Hi Mike,
> Im running into some strange errors in my testing - I'm not sure if they're
> related tp the patch so I'll do some more testing and update next weel.
related *to the patch,
update next *week:

I think the patch looks good so you can go ahead and check this in,
Thanks.
Comment 3 Michael Rennie CLA 2011-03-22 13:44:38 EDT
applied patch to HEAD