Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339267

Summary:

TrayDialog closes the tray if the help button is pressed with a cheat sheet open

Product:

[Eclipse Project] Platform

Reporter:

Chris Goldthorpe <cgold>

Component:

Assignee:

Markus Keller <markus.kell.r>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, markus.kell.r, remy.suen

Version:

3.7

Target Milestone:

3.7 M7

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch 0.1	none

Description Chris Goldthorpe

2011-03-08 13:25:21 EST

I20110307-0800

Help/Cheat Sheets
Open Java Development/Create a Hello World Application. A cheat sheet will open.

Follow through the steps of the cheat sheet until you get to "Create a Java Project" and press the button to create the project. A New Java Project dialog will open.

Press the '?' button.

Expected result - help is shown in the tray
Actual result - the tray is closed

This is a regression caused by the fix for Bug 127852. We need to improve the logic that determines when to close the tray.

Comment 1 Markus Keller

2011-03-10 16:25:02 EST

Created attachment 190929 [details]
Patch 0.1

The problem is that the TrayDialog creates a help button, but it doesn't really know if the tray contains help or something else.

Here's a potential solution that would work without new APIs. It fixes comment 0, but it doesn't set the help button to 'pressed' state when the user opened help via F1 (and not via the help button).


For the perfect solution, we'd have to add something like DialogTray#isHelpTray(), which would be false for cheat sheets but true for actual help.

Comment 2 Chris Goldthorpe

2011-03-14 12:40:39 EDT

I think that Patch 0.1 is a perfectly good solution. I don't think that users who open the tray using F1 will expect that pressing the (?) will close the tray.

Comment 3 Markus Keller

2011-03-14 13:34:08 EDT

(In reply to comment #2)
> I think that Patch 0.1 is a perfectly good solution.

Thanks, released to HEAD.

Comment 4 Markus Keller

2011-04-27 08:41:13 EDT

Verified in I20110426-2000.