Bugzilla – Full Text Bug Listing
| Summary: | [quick assist] "Change modifiers to final where possible" too prominent | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Deepak Azad <deepakazad> | ||||
| Component: | UI | Assignee: | Deepak Azad <deepakazad> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | markus.kell.r | ||||
| Version: | 3.7 | ||||||
| Target Milestone: | 3.7 M7 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Hmm, I'm not sure. If you already have an equals() method, then "Generate hashCode() and equals()" will override that method with a generated boilerplate implementation that is often not the best solution for the specific problem. I'd rather encourage people to take a breath and think about how to be implement hashCode(), rather than proposing to use a generated method. People who often need to implement these methods should better use one of the many available frameworks. Wheew, I missed the "Change modifiers to final where possible" quick assist that shows up when "A" is selected (with and without a problem on A). My comment 1 assumed you wanted to change the ordering of the 2 applicable quick fixes. The quick assist is completely wrong and should never be shown in this situation. I'm not even sure if it should be shown in any situation :-/ Unless someone sees a god reason, we should remove the quick assist completely. Users can use the Clean Up if they want to suffer from 'final' measles. (In reply to comment #2) > Unless someone sees a god reason, we should remove the quick assist completely. I meant a "good" reason, of course. Deepak, can you please remove the quick assist? Created attachment 192913 [details]
fix+tests
Markus, as discussed on sametime I have reduced the visibility of the quick assist. Now it only works inside the selection, i.e. it does not show up when only "A" is selected, but it show up when the whole class or the whole equals method or a set of statements are selected.
Fixed in HEAD. |
----------------------------------------------------------- package p; class A { // warning here int a; @Override public boolean equals(Object obj) { if (this == obj) return true; if (obj == null) return false; if (getClass() != obj.getClass()) return false; ClassA other = (ClassA) obj; if (a != other.a) return false; return true; } } ---------------------------------------------------------- - Enable 'Class overrides equals() but not hashcode()' warning - Click on the warning in the vertical ruler - 'Override hascode()' is number 2 and 'Generate hashcode and equals' is number 3. Expected: These should be 1 and 2.