Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339129

Summary: Perspective reset actions are not consistent.
Product: [Eclipse Project] Platform Reporter: Oleg Besedin <ob1.eclipse>
Component: UIAssignee: Oleg Besedin <ob1.eclipse>
Status: VERIFIED FIXED QA Contact: Oleg Besedin <ob1.eclipse>
Severity: normal    
Priority: P3 CC: bokowski, daniel_megert, ob1.eclipse
Version: 3.7   
Target Milestone: 3.7 M7   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch
none
Screenshot
none
Patch 2 none

Description Oleg Besedin CLA 2011-03-07 14:00:32 EST 
There are two perspective reset actions: one from the toolbar area and one in the preference page.  The behaviour of these actions is different.

If there is customization to the perspective, the "Reset perspective" command available from the perspective switcher resets perspective to the customized version, not pre-defined layout.

The "Reset" button on Perspectives preferences page reset perspective to the pre-defined layout discarding customization.

Issues:
1. The different behavior associated with those 2 "reset" button.
2. The "true" reset button is very hard to discover.
Comment 1 Oleg Besedin CLA 2011-03-07 14:03:12 EST 
Created attachment 190587 [details]
Patch
Comment 2 Oleg Besedin CLA 2011-03-07 14:07:45 EST 
Created attachment 190588 [details]
Screenshot

The message box that will be shown on the perspective's switcher "Reset perspective" when we deal with a pre-defined customized perspective.

The patch changes note on the Perspective's preferences page to read:

   Reset removes customization of a predefined perspective.
   It takes effect the next time the perspective is opened
Comment 3 Boris Bokowski CLA 2011-03-07 15:20:39 EST 
Maybe use the word "Revert" instead of "Reset" in the preference page?
Comment 4 Oleg Besedin CLA 2011-03-07 16:03:26 EST 
Created attachment 190600 [details]
Patch 2

(In reply to comment #3)
> Maybe use the word "Revert" instead of "Reset" in the preference page?

Good idea. I'll also update the screenshot for the preference page in 

   org.eclipse.platform.doc.user\images\Image223_pref_persp.png
Comment 5 Oleg Besedin CLA 2011-03-14 10:10:52 EDT 
Patch applied to CVS Head.
Comment 6 Dani Megert CLA 2011-03-16 07:19:01 EDT 
Looks good!

The note on the preference page should use 'Revert' instead of "Revert" and I would tweak it a bit. How about:

RevertPerspective_note='Revert' removes the customization from the selected perspective.\nThis only applies to newly opened perspectives.
Comment 7 Oleg Besedin CLA 2011-03-17 12:05:45 EDT 
(In reply to comment #6)
> Looks good!
> 
> The note on the preference page should use 'Revert' instead of "Revert" and I
> would tweak it a bit. How about:
> 
> RevertPerspective_note='Revert' removes the customization from the selected
> perspective.\nThis only applies to newly opened perspectives.

Done, thank you for the text. Also updated the screenshot.
Comment 8 Dani Megert CLA 2011-03-18 03:38:43 EDT 
Verified in N20110317-2000.