Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339080

Summary:	API tool errors in latest SWT
Product:	[Eclipse Project] Platform	Reporter:	Paul Webster <pwebster>
Component:	UI	Assignee:	Paul Webster <pwebster>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	bokowski, kim.moir, ob1.eclipse, Olivier_Thomann, remy.suen, Silenio_Quarti
Version:	3.7
Target Milestone:	3.7 M6
Hardware:	PC
OS:	Linux
Whiteboard:

Description Paul Webster

2011-03-07 07:38:58 EST

I checked out SWT from HEAD, and get the following API errors ... they propagate upwards, and are demanding we update org.eclipse.jface and org.eclipse.ui to 4.x.x.

PW


Description	Resource	Path	Location	Type
Invalid @since 3.2 tag on getGCData(); expecting @since 3.7	GC.java	/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics	line 2	@since tag problem
Invalid @since 3.3 tag on internal_new(Display, long); expecting @since 3.7	Shell.java	/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets	line 2	@since tag problem
The major version should be incremented in version 3.7.0.qualifier, since API breakage occurred since version 3.6.0.I20100601-0800	MANIFEST.MF	/org.eclipse.jface/META-INF	line 5	Version Numbering Problem
The major version should be incremented in version 3.7.0.qualifier, since API breakage occurred since version 3.6.0.I20100603-1100	MANIFEST.MF	/org.eclipse.ui/META-INF	line 5	Version Numbering Problem
The major version should be incremented in version 3.7.0.qualifier, since API breakage occurred since version 3.6.0.v3650b	MANIFEST.MF	/org.eclipse.swt/META-INF	line 5	Version Numbering Problem
The method org.eclipse.swt.graphics.Device.internal_dispose_GC(long, GCData) that has to be implemented has been added	Device.java	/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics	line 1	Compatibility Problem
The method org.eclipse.swt.graphics.Device.internal_new_GC(GCData) that has to be implemented has been added	Device.java	/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics	line 1	Compatibility Problem
The method org.eclipse.swt.graphics.Drawable.internal_dispose_GC(long, GCData) in an interface that is intended to be implemented has been added	Drawable.java	/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics	line 1	Compatibility Problem
The method org.eclipse.swt.graphics.Drawable.internal_new_GC(GCData) in an interface that is intended to be implemented has been added	Drawable.java	/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics	line 1	Compatibility Problem
The re-exported type org.eclipse.swt.browser.WebKit in org.eclipse.jface_3.6.0 is no longer API	WebKit.java	/org.eclipse.swt/Eclipse SWT WebKit/gtk/org/eclipse/swt/browser	line 1	Compatibility Problem
The re-exported type org.eclipse.swt.browser.WebKit in org.eclipse.ui_3.6.0 is no longer API	WebKit.java	/org.eclipse.swt/Eclipse SWT WebKit/gtk/org/eclipse/swt/browser	line 1	Compatibility Problem

Comment 1 Grant Gayed

2011-03-07 11:52:04 EST

I don't see any of the swt-level errors when I load swt into my workspace.  I assume that these have just appeared for you in the last week, since they're not listed in bug 335887?  If so then something strange is happening here, since (for instance) GC has not changed on gtk since 3.6.x.  I notice that your loaded swt is 64-bit, could this be involved? (eg.- comparing against a 32-bit baseline?  Or ints/longs not fully flipped?).  I know this would not explain cases like GC.getGCData(), but I've confirmed that this signature has not changed since 3.2.

Regarding the WebKit errors, these are introduced by the fix for bug 335887.  This is a class that was never intended to be public, and should not have any clients.  Are you able to add a filter for this at your level?

Comment 2 Paul Webster

2011-03-07 12:46:55 EST

(In reply to comment #1)
> Regarding the WebKit errors, these are introduced by the fix for bug 335887. 
> This is a class that was never intended to be public, and should not have any
> clients.  Are you able to add a filter for this at your level?

Most of my errors then might be related to the 32-64 transform I ran.

I'll look at adding filters for the other 2 (it's a side effect of our bundles simply re-exporting SWT, I'm sure).

PW

Comment 3 Paul Webster

2011-03-08 08:04:56 EST

Oleg, we just need to add API filters in org.eclipse.jface and org.eclipse.ui to deal deal with the change in WebKit.

PW

Comment 4 Oleg Besedin

2011-03-08 09:27:40 EST

I have Windows and Mac computers and I don't see API errors when using 3.6 as a baseline.

Is this something specific to Linux?

Comment 5 Paul Webster

2011-03-08 10:18:49 EST

released to HEAD
PW

Comment 6 Paul Webster

2011-03-08 13:35:49 EST

I no longer see the errors in my workspace.
PW