Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 339022

Summary:	[reconciling] ASTProviderTest fails and is not in CoreTests suite
Product:	[Eclipse Project] JDT	Reporter:	Markus Keller <markus.kell.r>
Component:	Text	Assignee:	Dani Megert <daniel_megert>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	deepakazad
Version:	3.7
Target Milestone:	3.7 M7
Hardware:	All
OS:	All
Whiteboard:

Description Markus Keller

2011-03-05 18:54:29 EST

HEAD

ASTProviderTest fails and is not in CoreTests suite.

Comment 1 Markus Keller

2011-03-05 18:58:54 EST

Problem is probably the magic '35' (offset moves if line.separator is two characters long).

Comment 2 Deepak Azad

2011-03-05 22:25:40 EST

It passes for me...

Comment 3 Deepak Azad

2011-03-05 22:34:48 EST

...and on the Linux on the build machine.

Comment 4 Markus Keller

2011-03-06 16:14:14 EST

Yeah, the test is sometimes green -- but only in case it didn't really work. Set a breakpoint on line 135 at assertEquals(..) and see how it *never* gets hit (because "ast" is always null).

Dani, please have a look. If I understood bug 181257 correctly, the test should actually
- use "33" as offset on line 72
- use the SharedASTProvider.WAIT_ACTIVE_ONLY flag
- assertNotNull(ast)

Comment 5 Dani Megert

2011-03-24 08:11:07 EDT

Fixed in HEAD. Also fixed a bug in AbstractReconciler.java (rev. 1.41).
Available in builds >= N20110324-2000.