| Summary: | Import wizard should show p2 dependency resolution errors | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Pascal Rapicault <pascal> | ||||||
| Component: | m2e | Assignee: | Igor Fedorenko <igor> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | igor, mkleint | ||||||
| Version: | unspecified | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Pascal Rapicault
We can discuss it during the call. aren't the dependency resolution problems rooted in wrong content of the m2e discovery repository? let's take an example of wtp. I assume that if wtp is not installed and we find the mapping in m2e discovery repository, we shall have everything in order to install it. If we don't, what is the point of showing the error? Maybe just not show anything? Or if we do have to show an error it should say: "You don't have WTP installed" or "For better web support, install WTP". "You have incompatible version of WTP". But my fear is that the messages we have readily available are those long ones that mention Installable unit IDs and dependency versions. I don't consider these helpful. They will not fit inside the table, we will have to perform tricks on the UI to show the selected error in the page's header and it still won't fit. And the ui simplicity/consistency wil suffer. on the technical side of things, where in the code are those messages stored? Created attachment 190665 [details]
Modification for Import Wizard
Unfortunately the messages are the p2 dependency errors, I don't believe we can do better. Some of the errors can potentially be different library versions which may not be something we can present to the user.
Created attachment 190666 [details]
Import Wizard Insallation Improvements
I accidentally included a change in the previous patch to point the discovery UI at a local site.
I pushed the patch with a trivial change (did not compile due to missing import) but this bug still needs some loving I've change the import wizard to use MavenDiscoveryInstallOperation (in a not so nice wizard on top of wizard manner). This means that all p2 resolution is handles by the same code and GUI elements that are used by m2e marketplace and quick fixes, which presumably provides better error messages. |