Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338847

Summary:

Cancel button in edit launch config does not really cancel

Product:

[Eclipse Project] Platform

Reporter:

Samantha Chan <chanskw>

Component:

Debug

Assignee:

Michael Rennie <Michael_Rennie>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

pawel.1.piech

Version:

3.6

Flags:

pawel.1.piech: review+

Target Milestone:

3.7 M7

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
fix	none

Description Samantha Chan

2011-03-03 15:11:35 EST

1.  selecting a running launch config from debug view
2.  rmc -> edit launch config
3.  make some change to the launch config
4.  click continue

You will be prompted to save, click cancel.

The cancel button is treated the same as No.
The expected behavior is to go back to the LCD and allow the user to modify their changes.

Comment 1 Pawel Piech

2011-03-03 17:02:32 EST

It always struck me as odd as well.  Do you propose to Replace the "Continue" buttoms with "Apply + Cancel".

Comment 2 Samantha Chan

2011-03-03 23:27:48 EST

(In reply to comment #1)
> It always struck me as odd as well.  Do you propose to Replace the "Continue"
> buttoms with "Apply + Cancel".

There are two sets of buttons:
1)  the cancel and continue button with the Edit launch config dialog
2)  After clicking continue, a confirmation to save changes dialog, has three buttons, yes, no and cancel.

I think the buttons in edit launch config dialog is confusing as well... (though not what I originally complained about.)  I agree that apply and cancel will make more sense.  However, we are using this dialog is a slightly different context, and the label "continue" makes more sense to us.  Can we modify the labels on the button?  you already have a flag to disable the cancel button.

The original defect complained about the cancel button in teh save confirmation dialog.  The cancel now just causes the LCD to exit.  But the expected behavior is that it cancels the save, and bring the user back to the LCD.

Comment 3 Samantha Chan

2011-03-03 23:28:48 EST

I mean.. can we have capability to customize the labels of the buttons in the edit launch config dialog?

Comment 4 Pawel Piech

2011-03-04 01:13:49 EST

(In reply to comment #2)
> The original defect complained about the cancel button in teh save confirmation
> dialog.  The cancel now just causes the LCD to exit.  But the expected behavior
> is that it cancels the save, and bring the user back to the LCD.
I see.  Without looking I just thought it was "Yes" and "Cancel".  I personally find this confirmation dialog completely unnecessary.  I would rather that the edit dialog had OK and Cancel.  I seem to remember that this is the way it used to be and people complained about Cancel not canceling after user pressed Apply, but IMO if it's good enough for preferences dialog it should be good enough for LCD. 

(In reply to comment #3)
> I mean.. can we have capability to customize the labels of the buttons in the
> edit launch config dialog?

I have no problem with that.  It would a new API though...

Comment 5 Michael Rennie

2011-03-22 13:19:02 EDT

Created attachment 191703 [details]
fix

The patch makes the edit dialog have the same behavior as the other launch configuration dialog variants.

Comment 6 Michael Rennie

2011-03-22 13:21:19 EDT

applied patch to HEAD

Comment 7 Pawel Piech

2011-03-22 13:32:59 EDT

That's so much more logical :-)