Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338845

Summary: [Help] Upgrade org.eclipse.help.base to Java 1.5
Product: [Eclipse Project] Platform Reporter: Chris Austin <ChrisAustin>
Component: User AssistanceAssignee: platform-ua-inbox <platform-ua-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: cgold, john.arthorne, remy.suen
Version: 3.7   
Target Milestone: 3.8 M3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 308035    

Description Chris Austin CLA 2011-03-03 14:22:08 EST
We should bring org.eclipse.help.base to 1.5 because we will be able to fix a proxy bug that has been around for a long time.

Plugin org.eclipse.help.base indirectly depends on org.eclipse.osgi (which is at 1.5) so the effects of this upgrade should be minimal.
Comment 1 Chris Goldthorpe CLA 2011-03-03 14:37:52 EST
John, can we still make this change for Eclipse 3.7? Given that we are approaching the end of M6 this would have to happen in M7.
Comment 2 John Arthorne CLA 2011-03-03 22:05:48 EST
It is not too late. But, given that M6 is the API freeze, you would need to be careful about any API impact. I assume from the description that this involves making using of some new Java 5 class library function, rather than wholesale upgrade of the API and code base to use generics, etc?

It is actually incorrect that org.eclipse.osgi depends on 1.5. It uses Java 5 syntax, but that is erased during compilation and its runtime dependency is on a subset of Foundation 1.2 (itself a subset of Java 1.4). But that isn't particularly important - if you have a need for Java 5 then you can use it.
Comment 3 Chris Goldthorpe CLA 2011-04-06 17:06:18 EDT
Deferring till Eclipse 3.8
Comment 4 Chris Goldthorpe CLA 2011-09-29 17:19:25 EDT
We need to upgrade to using Java 1.5 before we can switch to use Lucene 3.4. so I am going to go ahead with this. Chris A, what was the proxy bug that you referred to in the description? Can you create a dependency from that bug to this one?
Comment 5 Chris Goldthorpe CLA 2011-09-30 13:21:57 EDT
Fixed in master, with commit message:

Bug 338845 - [Help] Upgrade org.eclipse.help.base to Java 1.5