Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338818

Summary: [Tooling] Avoid launching a RAP application with wrong windowing system
Product: [RT] RAP Reporter: Beyhan Veliev <beyhan.veliev>
Component: DemoAssignee: Project Inbox <rap-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: enhancement    
Priority: P3 CC: rsternberg
Version: 1.4   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard:
Bug Depends on: 338544    
Bug Blocks:    
Attachments:
Description Flags
Version 1
none
Version 2 rsternberg: iplog+

Description Beyhan Veliev CLA 2011-03-03 09:55:42 EST 
RAP defines its own windowing system see bug 338544. Therefore, RAP applications have to be launched with osgi.ws=rap. 
* disable launch button if osgi.ws has a wrong value 
* show an appropriate error message which helps the user to set the right windowing system value.
Comment 1 Beyhan Veliev CLA 2011-03-04 10:19:59 EST 
Created attachment 190393 [details]
Version 1

This patch adds '-ws' validation to RAP launcher. If '-ws' is not set or has a wrong value RAP launcher displays a warning on its title area.  I decided to display an warning instead of an error because I found it too annoying. Any other suggestions here?

What about to open a warning dialog like 'Port in use' before launch if '-ws' isn't set properly? It is possible that a user has a RAP launch configuration and launches it from the context menu. In this use case we can warn the user only with an warning dialog like 'Port in use'.
Comment 2 Beyhan Veliev CLA 2011-03-11 09:39:31 EST 
Created attachment 190984 [details]
Version 2

Patch reviewed:
* some refectoring done
* new tests added
* warning message updated
Comment 3 Ralf Sternberg CLA 2011-03-11 09:46:07 EST 
Applied second patch to CVS HEAD.
As an improvement, we could think about showing the warning only when the RAP runtime is >= 1.4M6. OTOH, setting the ws for older runtimes won't hurt.
Comment 4 Ralf Sternberg CLA 2011-03-11 14:54:39 EST 
(In reply to comment #3)
> As an improvement, we could think about showing the warning only when the RAP
> runtime is >= 1.4M6. OTOH, setting the ws for older runtimes won't hurt.

Thinking about it some more, I believe that this tweak would not be worth the effort. Users who work with the new tooling but still use an old target will have to live with this warning or to change the window system in the target.
Closing as FIXED.
Comment 5 Ralf Sternberg CLA 2011-03-14 06:21:50 EDT 
We had to roll back the changes to bug 338544 because of unexpected side effects. Until we have a solution for them, we should disable the warning.
Comment 6 Ivan Furnadjiev CLA 2013-12-10 03:32:52 EST 
We have a working solution for bug 338544 not based on specific RAP windowing system. Close as WONTFIX.