Bug 338813

Comment 1 Nicolas Guyomar 2011-03-03 09:35:56 EST

Created attachment 190272 [details]
Bug 338813

Hi,

Please find attached a patch on the plug-in org.eclipse.emf.facet.efacet.core

This patch provides a new interface IFacetAction, which exposes the required actions.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar

Comment 2 Gregoire Dupe 2011-03-17 10:56:01 EDT

Comment on attachment 190272 [details]
Bug 338813

Here are a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

We still need to provide unit tests.

Comment 3 Nicolas Guyomar 2011-03-18 05:49:26 EDT

Created attachment 191491 [details]
Test Plug-in org.eclipse.emf.facet.efacet.core.tests

Hi,

Please find attached a complete set of test for the interface IFacetAction.

This set of test comes within a new test plug-in.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards,
Nicolas Guyomar

Comment 4 Gregoire Dupe 2011-03-18 07:08:16 EDT

Comment on attachment 191491 [details]
Test Plug-in org.eclipse.emf.facet.efacet.core.tests

Here is a contribution from one employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this contribution.

Committed revision 433.

Comment 5 Gregoire Dupe 2011-03-18 09:06:44 EDT

Hello,

Before to mark this bug as resolved, we need an additional operation in the API (and its unit tests): 

  IFacetAction.createFacetSet(FacetSet, IProject): FacetSet

Regards,
Gregoire Dupe

Comment 6 Nicolas Guyomar 2011-06-16 10:06:43 EDT

Created attachment 198106 [details]
Patch for Bug 338813 missing method

Hi,

Please find attached the missing IfacetAction.createFacetSet(FacetSet facetSet, IFile file)

The method signature is IFile instead of IProject because we need to create a facetSet in a file, which carries it own URI

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Comment 7 Nicolas Guyomar 2011-06-16 10:43:55 EDT

Created attachment 198112 [details]
Patch for Bug 338813 missing xfriend

Hi,

Please find attached a necessary package exposition from org.eclipse.emf.facet.util.emf.core to expose InvalidFacetSetException needed in org.eclipse.emf.facet.efacet.core.IFacetAction

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Regards,
Nicolas Guyomar

Comment 8 Nicolas Bros 2011-09-23 04:56:59 EDT

Comment on attachment 198106 [details]
Patch for Bug 338813 missing method

This is a contribution from an employee of Mia-Software, targeting a future
Juno release. The company has signed a Member Committer Agreement. The
contribution does not need a CQ (see bug 322327).

Committed in revision 862.

Comment 9 Nicolas Bros 2011-09-23 04:57:23 EDT

Comment on attachment 198112 [details]
Patch for Bug 338813 missing xfriend

This is a contribution from an employee of Mia-Software, targeting a future
Juno release. The company has signed a Member Committer Agreement. The
contribution does not need a CQ (see bug 322327).

Committed in revision 863.

Comment 10 Nicolas Bros 2011-09-23 04:58:03 EDT

Patches committed; marking the bug as fixed.

Comment 11 Gregoire Dupe 2012-05-22 10:32:43 EDT

This bug can be closed.