Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338653

Summary: [cdt] Add support for CDT launch config types
Product: [Tools] TCF Reporter: Anton Leherbauer <aleherb+eclipse>
Component: DebugAssignee: Project Inbox <tcf.debug-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: eugene
Version: unspecified   
Target Milestone: 0.4.0   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Proposed patch
mober.at+eclipse: iplog+
Launch config icon
mober.at+eclipse: iplog+
Patch to tcf.debug
none
Patch to tcf.debug (2)
mober.at+eclipse: iplog+
Add icons directory to binary build mober.at+eclipse: iplog+

Description Anton Leherbauer CLA 2011-03-02 07:01:23 EST
CDT defines launch configuration types

- C/C++ Application
- C/C++ Attach to Application

which are supported by different launch config delegates for DSF-GDB and CDI.
Similarly, TCF launch delegates should be created to support these generic launch config types.

Additionally a "TCF Remote Application" launch configuration type should be created to support launching remote processes.  This would be similar to the existing "C/C++ Remote Application" launch config type for RSE connections defined in org.eclipse.cdt.launch.remote.
Comment 1 Anton Leherbauer CLA 2011-03-02 08:48:52 EST
Created attachment 190140 [details]
Proposed patch
Comment 2 Anton Leherbauer CLA 2011-03-02 08:49:46 EST
Created attachment 190142 [details]
Launch config icon
Comment 3 Eugene Tarassov CLA 2011-03-03 14:23:33 EST
Cool!
I have committed the patch.
I also made a couple small fixes in the code for NPE and assertion failure.
Thanks!
Comment 4 Anton Leherbauer CLA 2011-03-04 02:40:43 EST
Created attachment 190356 [details]
Patch to tcf.debug

Thanks for committing!
Unfortunately the patch was incomplete. (Sometimes SVN is cheating on me.)  
It did not contain the changes to the tcf.debug plug-ins which I am attaching now.

The patch contains changes to
- allow to attach to a process without starting it.
- fix source lookup in case a non-TCF source locator is associated with a launch
  (This can happen with CDT launch configs)
- assign IDs to TCFTargetTab and TCFPathMapTab so that they can be referenced in 
  plugin.xml.
Comment 5 Anton Leherbauer CLA 2011-03-04 02:45:23 EST
Created attachment 190357 [details]
Patch to tcf.debug (2)

Fixed a typo in last patch.
Comment 6 Eugene Tarassov CLA 2011-03-04 15:02:25 EST
I have committed tcf.debug patch.
Thanks!
Comment 7 Anton Leherbauer CLA 2011-03-08 03:24:15 EST
Created attachment 190624 [details]
Add icons directory to binary build

One last thing: the new icons directory must be added to build.properties.
Comment 8 Eugene Tarassov CLA 2011-03-08 12:44:18 EST
(In reply to comment #7)
> Created attachment 190624 [details]
> Add icons directory to binary build
> 
> One last thing: the new icons directory must be added to build.properties.

The patch does not include plugin name.
I assume it is org.eclipse.tm.tcf.cdt.ui.
Committed.
Thanks!
Comment 9 Martin Oberhuber CLA 2013-05-23 19:47:27 EDT
Comment on attachment 190624 [details]
Add icons directory to binary build

Anton was elected TCF committer on 24-Mar-2011:
http://dev.eclipse.org/mhonarc/lists/tcf-dev/msg00028.html

Thus any contributions before that time must be marked iplog+