Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338642

Summary:	Arguments constructed from the option pane in the tool.xml incorrectly split into tokens
Product:	[Tools] PTP	Reporter:	Tan Wen Jun <tanw0076>
Component:	ETFw	Assignee:	Wyatt Spear <wspear>
Status:	ASSIGNED ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	g.watson, tanw0076, wspear
Version:	6.0.3	Keywords:	needinfo
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Tan Wen Jun

2011-03-02 05:27:42 EST

In org.eclipse.ptp.etfw.toolopts.ToolApp, the function "public List<String> getArguments(ILaunchConfiguration configuration)" incorrectly assumes that the value returned from allInput[i].getArgument(configuration) contains only 1 argument. Therefore the split only works for 1 argument.

Incorrect splitting of arguments can cause the external tool to fail as the arguments passed to the tool is different.

Comment 1 Greg Watson

2011-09-14 10:03:15 EDT

Adding Wyatt to CC as he is looking at ETFw currently.

Comment 2 Wyatt Spear

2012-09-24 13:31:57 EDT

Can I get a specific example of where/how this is causing a tool to fail?  The final argument string should be reassembled without loss of information even if it wasn't fully split.  This code needs to be revisited anyway because it isn't safe to assume that arguments are split on a 'space/dash'.

Comment 3 Greg Watson

2014-06-09 16:43:24 EDT

This bug can't be addressed without further information.