Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338638

Summary:

[quick assist][quick fix] Relevance for externalization quick fixes too low with non-empty selection

Product:

[Eclipse Project] JDT

Reporter:

Ankur Sharma <ankur_sharma>

Component:

Assignee:

Markus Keller <markus.kell.r>

Status:

VERIFIED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

daniel_megert, deepakazad, markus.kell.r, raksha.vasisht

Version:

3.7

Target Milestone:

3.7 M6

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
snapshot	none
Snapshot	none

Description Ankur Sharma

2011-03-02 05:13:14 EST

The order for string externalization quick fixes is different when invoked by clicking on the marker on the left margin compared to one that comes by pressing Ctrl + 1 on the non-NLS'ed string.

See snapshots

Comment 1 Ankur Sharma

2011-03-02 05:13:40 EST

Created attachment 190116 [details]
snapshot

Comment 2 Ankur Sharma

2011-03-02 05:19:42 EST

Created attachment 190120 [details]
Snapshot

Comment 3 Dani Megert

2011-03-02 05:24:42 EST

Nope, it's not different. When you click on the ruler then you click on the warning and hence Quick Fix/Assist is invoked on that selection. If you use Ctrl+1 on that selection you'll get the same ordering.

Comment 4 Ankur Sharma

2011-03-02 05:37:11 EST

When clicking on the warning and hence quick fix being triggered, shouldn't the 'fix' that fixes the problem should be of top relevance?  That is, the non-nls and externalize string quick fix should be shown on top.

Comment 5 Dani Megert

2011-03-02 05:42:32 EST

There could be more than one warning/error and below could be the quick assist icon/trigger. We simply select the most relevant selection and invoke Ctrl+1, so that you get exactly the same result as when invoking Ctrl+1 on the selection manually.

Comment 6 Markus Keller

2011-03-02 12:48:19 EST

Dani is right that the order is consistent if the selection is the same, but I also agree with comment 4.

I've increased the relevance of the nls proposals to beat the Extract... ones even if there is a selection.

Fixed in HEAD of LocalCorrectionsSubProcessor.

Comment 7 Deepak Azad

2011-03-02 13:01:14 EST

The fix looks good, thanks Markus!

Ankur, thanks for the bug report :)

Comment 8 Raksha Vasisht

2011-03-07 03:25:26 EST

Verified the order is correct for 3.6 M6 with N20110305-2000.