Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338636

Summary:

some cell editors need an initial value

Product:

z_Archived

Reporter:

Nicolas Bros <nicolas.bros>

Component:

EMF-Facet

Assignee:

Nicolas Bros <nicolas.bros>

Status:

CLOSED WORKSFORME

QA Contact:

Severity:

enhancement

Priority:

CC:

emft.facet-inbox, fabien.giquel, gdupe

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch	gdupe: iplog-

Description Nicolas Bros

2011-03-02 04:51:17 EST

Add a context parameter to createCompositeEditor in org.eclipse.emf.facet.widgets.celleditors.core.composite.CompositeEditorFactory<T>.

Comment 1 Nicolas Bros

2011-03-02 05:36:15 EST

Created attachment 190125 [details]
patch

Comment 2 Fabien Giquel

2011-03-02 07:30:35 EST

Hi Nicolas,

after internal debate about this evolution, it seems better to provide some 'T initialValue' parameter rather than 'Object context'.

The client is in charge of building the initialValue contextually to its needs. Neither the "CompositeEditorFactory" sublass nor the T class have to know how to process a context.

Comment 3 Nicolas Bros

2011-03-02 09:57:27 EST

There is no need to change anything on the EMF Facet side. 
When used in a JFace context, the framework initializes the cell editor's value with the value it gets from the EditingSupport.

Comment 4 Gregoire Dupe

2012-05-23 08:13:52 EDT

This bug can be closed.