Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338618

Summary:	[client] commands that supply hrefs should render as anchors so user can manage browser tabs
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	bokowski, john.arthorne
Version:	0.2
Target Milestone:	0.2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2011-03-01 23:27:13 EST

In the command service we have a notion of a "link" command, which can contain an href rather than a callback.  This allows us to represent "commands" that really just change the page.  When contributed as a link in a toolbar, the user can choose whether to click or ctrl-click the link and the right stuff happens.

But when we are rendering inside a menu, we currently just change the window location.  The user has no way to decide whether to open a new page or not.

No matter which way we decide to handle it, we'll be wrong for half for users.  ;-)  So we need a way to put a real anchor tag in the menu.

Comment 1 Boris Bokowski

2011-03-09 11:33:50 EST

If possible we should solve this for M7.

Comment 2 Susan McCourt

2011-04-21 17:04:08 EDT

fixed.
It was pretty straightforward to get the html into the menu item.
That allowed things like hovering over the link to work, the browser context menu, etc.

The harder part was that the dojo menu seems to want to eat the onclicks rather than let the underlying html elements handle it.  So I had to code the onclick behavior to follow the link location (and check for the right modifier keys, etc.)

However it appears to be working now.