Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338564

Summary:

The "Serve modules without publishing" feature is broken with Tomcat 7.0.9 and later

Product:

[WebTools] WTP ServerTools

Reporter:

Larry Isaacs <larryisaacs>

Component:

jst.server

Assignee:

Larry Isaacs <larryisaacs>

Status:

RESOLVED FIXED

QA Contact:

Angel Vera <arvera>

Severity:

major

Priority:

Flags:

arvera: review+

Version:

3.2

Target Milestone:

3.2.4

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Changes to plug-in code to handle another version of loader jar	none
Updated loader jar for Tomcat 7.0.9 and later	none
Updated source zip for Tomcat 7.0.9 and later loader jar	none

Description Larry Isaacs

2011-03-01 12:34:55 EST

Created attachment 190064 [details]
Changes to plug-in code to handle another version of loader jar

Some improvements were made to Tomcat's FileDirContext class (after Tomcat 7.0.8) which makes the WtpDirContext class that extends FileDirContext incompatible for Tomcat 7.0.9 and later.  An updated version of the loader jar is needed for the "Serve modules without publishing" feature to work with Tomcat 7.0.9 and later.

The fix will build on the work done in Bug 335646 which provides loader jars specific to particular versions of Tomcat 7.0.x.  The current versions of org.eclipse.jst.server.tomcat.runtime.70.loader.jar and org.eclipse.jst.server.tomcat.runtime.70.loader-src.zip will become org.eclipse.jst.server.tomcat.runtime.708.loader.jar and org.eclipse.jst.server.tomcat.runtime.708.loader-src.zip, respectively.

Comment 1 Larry Isaacs

2011-03-01 12:36:06 EST

Created attachment 190065 [details]
Updated loader jar for Tomcat 7.0.9 and later

Comment 2 Larry Isaacs

2011-03-01 12:36:54 EST

Created attachment 190066 [details]
Updated source zip for Tomcat 7.0.9 and later loader jar

Comment 3 Larry Isaacs

2011-03-01 12:40:32 EST

I will go ahead and commit this (and Bug 335646 changes) to HEAD.  This update will be need to be included WTP 3.2.4, once it starts building.

Comment 4 Larry Isaacs

2011-03-18 11:12:26 EDT

Hi Angel,

Requesting approval to include this in WTP 3.2.4.  The only change to the WtpDirContext was to update a method to return List<NamingEntry> instead of ArrayList<NamingEntry>.  Fortunately, there are no other methods that WtpDirContext needs to override that return a collection class instead of a collection interface.

Thanks,
Larry

Comment 5 Angel Vera

2011-03-18 13:11:56 EDT

Sounds like a good one to fix.

Comment 6 Larry Isaacs

2011-03-18 14:56:57 EDT

Changes released to WTP 3.2.x maintenance for 3.2.4.  These changes are already present in WTP 3.3M6.