Bugzilla – Full Text Bug Listing
| Summary: | [editor] closure compiler complains that "char" is a reserved word | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Andrew Niefer <aniefer> |
| Component: | Client | Assignee: | Felipe Heidrich <eclipse.felipe> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | eclipse.felipe, john.arthorne, Silenio_Quarti, simon_kaegi |
| Version: | 0.2 | ||
| Target Milestone: | 0.2 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
Interesting. Closure appears to be incorrect. "char" is not a reserved word in ECMAScript or JavaScript: http://people.mozilla.org/~jorendorff/es5.html#sec-7.6.1 https://developer.mozilla.org/en/JavaScript/Reference/Reserved_Words Here is the closure bug... I guess its easier to just change our code anyway: http://code.google.com/p/closure-compiler/issues/detail?id=357 |
The running the google closure compiler during the releng build, it fails on editor.js complaining that "char" is a reserved word. [java] [java] /shared/eclipse/e4/orion/I201103010200/plugins/org.eclipse.orion.client.editor/web/js/editor.js:2802: ERROR - Parse error. missing variable name [java] if (char !== " ") { [java] ^ [java] [java] /shared/eclipse/e4/orion/I201103010200/plugins/org.eclipse.orion.client.editor/web/js/editor.js:2803: ERROR - Parse error. identifier is a reserved word [java] text += char; [java] ^