Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338523

Summary: [KeyBindings] Dialog is not closeable by ESC if keybinding with ESC key is defined
Product: [RT] RAP Reporter: Ivan Furnadjiev <ivan>
Component: WorkbenchAssignee: Project Inbox <rap-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 1.4   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 348559    

Description Ivan Furnadjiev CLA 2011-03-01 06:05:37 EST
With the resolution of bug 337883 we found that it's not possible to close anymore a dialog with ESC key if there is a keybinding defined for ESC key too and the keybinding contextId is org.eclipse.ui.contexts.dialogAndWindow or org.eclipse.ui.contexts.dialog.
Comment 1 Ralf Sternberg CLA 2012-02-17 12:19:31 EST
This issue exists with all _traversal_ keys: Arrow keys, Tab and Shift-Tab, Return and Escape.

The reason is that for key combinations that are registered as KeyBindings, the default behavior is suppressed using CANCEL_KEYS. But the JavaScript client does not distinguish between traversal and key events.

Since ESC is used to close shells, popup menus, Combo popup lists, cell editors, etc., I doubt that using ESC as a keybinding makes any sense.  The same applies for all other traverse events.  Therefore I would recommend *not to use Escape, Return, Tab, or the arrow keys as keybindings in RAP*.