Bugzilla – Full Text Bug Listing
| Summary: | javax.servlet.jsp-2.1 is broken since the tag v201101211721 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] Orbit | Reporter: | Hugues Malphettes <hmalphettes> | ||||
| Component: | bundles | Assignee: | Hugues Malphettes <hmalphettes> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | blocker | ||||||
| Priority: | P3 | CC: | david_williams, mober.at+eclipse | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
According to the history of the bundles.map file, the tag of javax.servlet.jsp_2.1 was changed from v201004190952 to v201101211721 on commit 1.593 by moberhuber while working on "Bug 329463 - Several about.html have invalid XHTML due to missing </p> tag" I am restoring the missing files. Also the about.html is changed and seems to assume that the sources of this jar were provided by apache when in fact these were provided by sun's glassfish project. Restored the files from the previously tagged version of javax.servlet.jsp-2.1 Re-applied the fix for the about.html. Fixed in tag v201103011838 CCing Margin for awareness. My guess is a weird cvs tagging problem? Must be some weirdness... and I have not maintained the psf files for the bundles I look after and Martin seems to use them. So maybe that would explain it. By the way many thanks to Martin for doing all this [un-rewarding] work on many different bundles. Those about.html spread like a viral marketing campaign in our bundles! (In reply to comment #4) It's possible that I had a cvs connection problem when I tagged... I faintly remember something along these lines. Although I checked bundles after tagging and they seemed OK (I think I performed a "Compare with ... released" after tagging). Another possibility is some oddness around CVS keyword substitution... I remember one bundle had a mixture of -kb and -ko settings. Not sure how this would affect individual files not being tagged. Looks like it's getting time we consider migrating to a CM system that supports transactions. The Git integration is getting mature... I don't think that the disruption could be related to the PSF. The PSF is sort of a courtesy to our committers, helping them populate their workspace easily. Anyways, I'm very sorry for any disruption that I might have caused. I should have verified actual bundles in the build after the change. Hope you're having things back under control? And BTW, thanks for the Kudos :) Martin Everything is fine now. Half embarrassed and half in denial at taking one month to notice this ;) As far as I know no-one found the issue so we are good. Phew - thanks. Perhaps the Comparator that David is working on could also help in cases like this somehow? In Orbit, we expect that for _any_ qualifier changes, the actual binary content of our bundles remains unchanged, we only allow changes to Manifest and about files. Could the comparator run in a mode where this could be checked? |
Created attachment 190028 [details] An idea of all the files and resources removed from javax.servlet.jsp-2.1 recently. A number of files and classes were removed: 3 xsd files in javax.servlet.jsp.resources 2 license files: ASL20 and CDDL 10 and more class files.