Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338484

Summary:

Provide enablement expression to ModuleFactory used by Java EE tools

Product:

[WebTools] WTP Java EE Tools

Reporter:

Roberto Sanchez Herrera <shr31223>

Component:

jst.j2ee

Assignee:

Roberto Sanchez Herrera <shr31223>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

ccc

Version:

3.2.3

Flags:

cbridgha: review+

Target Milestone:

3.2.4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Provide enablement to org.eclipse.wst.server.core.moduleFactories	none
Updated patch	ccc: iplog+

Description Roberto Sanchez Herrera

2011-02-28 18:06:10 EST

Build Identifier: WTP 3.2.4

This is more an enhancement than a defect. As part of bug 333617, an enablement expression was added to ModuleFactory extension point to prevent early loading of factories that are in use. This bug is to use that enablement expression in the ModuleFactory extension in Java EE tools code. 

Reproducible: Always

Comment 1 Roberto Sanchez Herrera

2011-03-07 13:16:49 EST

Created attachment 190580 [details]
Provide enablement to org.eclipse.wst.server.core.moduleFactories

Comment 2 Chuck Bridgham

2011-03-07 14:06:03 EST

Quick question....   didn't we have a separate module factory for EE5?

Can this class handle all EE5/5 model api's etc?

Comment 3 Roberto Sanchez Herrera

2011-03-07 17:41:56 EST

Created attachment 190606 [details]
Updated patch

Updated patch: the EE5 and EE6 module factory should accept EAR 5 and 6 facets only.

Comment 4 Roberto Sanchez Herrera

2011-03-07 17:42:28 EST

(In reply to comment #2)
> Quick question....   didn't we have a separate module factory for EE5?
> 
> Can this class handle all EE5/5 model api's etc?

The patch includes changes for the legacy module factory (in org.eclipse.jst.j2ee) and for the EE5 and EE6 module factory (in org.eclipse.jst.jee)

Comment 5 Chuck Bridgham

2011-03-17 10:47:38 EDT

approved

Comment 6 Carl Anderson

2011-03-28 11:00:21 EDT

Committed to R3_2_maintenance and HEAD for WTP 3.2.4 and WTP 3.3 M7