Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338444

Summary: Unable to restart after upgrade
Product: [Eclipse Project] e4 Reporter: John Arthorne <john.arthorne>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Remy Suen <remy.suen>
Severity: critical    
Priority: P3 CC: Olivier_Thomann, pwebster, remy.suen
Version: 0.2   
Target Milestone: 4.1 M6   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Error log
none
Old delta file that caused the failure on restart
none
Reconciler patch v1 none

Description John Arthorne CLA 2011-02-28 13:27:08 EST 
I upgraded from I20110114 to I20110225. After the upgrading, the workbench will not start. There are a large number of NPE's in the log. I will attach the whole log, but here are some example:

Caused by: java.lang.NullPointerException
	at org.eclipse.ui.internal.Workbench.contains(Workbench.java:1870)
	at org.eclipse.ui.internal.Workbench.defineBindingTable(Workbench.java:1852)


java.lang.NullPointerException
	at org.eclipse.ui.internal.Workbench.setReference(Workbench.java:1681)
	at org.eclipse.ui.internal.Workbench.access$19(Workbench.java:1677)
Comment 1 John Arthorne CLA 2011-02-28 13:27:38 EST 
Created attachment 189979 [details]
Error log
Comment 2 John Arthorne CLA 2011-02-28 13:29:26 EST 
I was able to restart by deleting my deltas.xml file. However this is not an acceptable step to require users to make on upgrade.
Comment 3 Paul Webster CLA 2011-02-28 13:30:56 EST 
As it stands now this is a known problem and a won't fix.  Any change to the schema is un-upgradable at the moment.



PW
Comment 4 John Arthorne CLA 2011-02-28 13:36:36 EST 
Preserving UI state after upgrade isn't critical, but having an upgrade result in a broken install that can never be started is no good. I would hope that we can at least detect that the deltas.xml refers to an old model version, and discard it automatically to allow the UI to come up.
Comment 5 Olivier Thomann CLA 2011-03-02 10:21:13 EST 
Created attachment 190157 [details]
Old delta file that caused the failure on restart

The file is zipped to make it smaller.
Comment 6 Remy Suen CLA 2011-03-02 10:40:32 EST 
Created attachment 190164 [details]
Reconciler patch v1

The old (and now unknown) changes are technically already being discarded but it seems that this causes a discord in the entire system preventing it from running. I have increased the version of the reconciler so that it will discard the deltas of previous versions.

Unfortunately, this will mean that your deltas will be discarded when the next build shows up (even though you are not actually affected by it anymore since you've been using a recent build). If you care about your state then modify your deltas.xml file manually by changing <changes version="1.0"> to <changes version="1.1">.
Comment 7 Remy Suen CLA 2011-03-02 10:41:35 EST 
(In reply to comment #6)
> Created attachment 190164 [details]
> Reconciler patch v1

Patch released to CVS HEAD.
Comment 8 Remy Suen CLA 2011-03-09 14:46:32 EST 
Verified that a workspace previously opened by I20110114-1005 can be opened by I20110307-2200.