Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338399

Summary: MPC blocks UI for unreachable marketplaces
Product: [Technology] MPC Reporter: Benjamin Muskalla <b.muskalla>
Component: wizardAssignee: Benjamin Muskalla <b.muskalla>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: greensopinion
Version: unspecified   
Target Milestone: 1.1   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
suggested fix
greensopinion: iplog+
mylyn/context/zip
none
patch with changes
none
mylyn/context/zip
none
mylyn/context/zip none

Description Benjamin Muskalla CLA 2011-02-28 06:40:14 EST 
Currently the UI will be blocked when opening the wizard in case there is an unreachable marketplace. This happens because CatalogDescriptor uses equals of URL. We should consider switching this to equals of URI instead of trying to resolve the hostname (and getting problems with virtual hosts, eg: marketplace1.eclipse.org and marketplace2.eclipse.org would end up being the same).
Comment 1 Benjamin Muskalla CLA 2011-02-28 06:41:43 EST 
Created attachment 189931 [details]
suggested fix

Here is the suggested fix
Comment 2 Benjamin Muskalla CLA 2011-02-28 06:41:46 EST 
Created attachment 189932 [details]
mylyn/context/zip
Comment 3 David Green CLA 2011-03-01 16:02:20 EST 
Created attachment 190091 [details]
patch with changes

I've made some minor changes to your patch that fix a problem where other.url == null.  What do you think?
Comment 4 David Green CLA 2011-03-01 16:02:23 EST 
Created attachment 190092 [details]
mylyn/context/zip
Comment 5 Benjamin Muskalla CLA 2011-03-08 05:10:14 EST 
Yes, looks good to me.
Comment 6 David Green CLA 2011-03-08 12:13:55 EST 
Fixed, thanks Benjamin.
Comment 7 David Green CLA 2011-03-08 12:13:56 EST 
Created attachment 190672 [details]
mylyn/context/zip