Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338373

Summary:

[navigation] FUP of bug 171019: adjust selection detector for @inheritDoc javadoc tag

Product:

[Eclipse Project] JDT

Reporter:

Ayushman Jain <amj87.iitr>

Component:

Assignee:

Markus Keller <markus.kell.r>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, markus.kell.r, raksha.vasisht, rthakkar

Version:

3.7

Target Milestone:

3.7 M6

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Fix	none

Description Ayushman Jain

2011-02-28 04:01:53 EST

Due to the fix for bug 171019, CTRL+CLICK on @inheritDoc tag behaves the same way as it does on a method name. This needs to be suitably changed.

Comment 1 Markus Keller

2011-02-28 09:34:23 EST

What do you want to have changed? I think it's fine as it is (works like an @see reference to the same method).

Comment 2 Ayushman Jain

2011-02-28 10:54:39 EST

(In reply to comment #1)
> What do you want to have changed? I think it's fine as it is (works like an
> @see reference to the same method).

I would expect the @inheritDoc tag to navigate to the method from where the javadoc is actually coming. CTRL+clicking on it, and chosing show declaration or implementation is a bit counter-intuitive, because if the user really wanted to do so, he'd have done the CTRL+click on the method name and not the javadoc tag. The choice "open return type" also seems a bit misplaced here.

I don't have a very strong reason to change this, but I feel navigation through inheritDoc tag should be precise, leading only to the method who's javadoc has been inherited.

Comment 3 Markus Keller

2011-02-28 12:22:40 EST

Created attachment 189969 [details]
Fix

OK, I've disabled the other hyperlinks and the hovers.

Comment 4 Markus Keller

2011-02-28 12:24:10 EST

Fixed in HEAD.

Comment 5 Raksha Vasisht

2011-03-07 00:51:04 EST

Verified for 3.7 M6 with N20110305-2000.

Comment 6 Rajesh

2011-03-08 12:16:22 EST

Verified on Mac with I20110307-2110