Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338153

Summary:	Compiled javascript out of sync with scripts in html
Product:	[ECD] Orion	Reporter:	Andrew Niefer <aniefer>
Component:	Client	Assignee:	Project Inbox <e4.orion-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	susan
Version:	0.2
Target Milestone:	0.2
Hardware:	PC
OS:	Linux
Whiteboard:

Description Andrew Niefer

2011-02-24 15:37:30 EST

The 3 main html files: navigate-table.html, navigate-tree.html and coding.html contain <script> tags surrounded by <!--START -->, <!--END --> and <!--INSERT--> comments.

At build time, these comments indicate sections that will be replace by a single <script> compiled using google-closure.

The releng system is not able to parse out the javascript files being included in the html, the contents of the compiled javascript replacement file are managed manually in org.eclipse.orion.releng/builder/scripts/closure.xml


If scripts are added or removed from these sections of the html file without making corresponding changes to the closure.xml script, then the releng built orion server will end up broken.

This has happened this week and I201102221025 has a broken navigator and editor.

Comment 1 Andrew Niefer

2011-02-24 15:39:22 EST

I updated the closure.xml with the changes for the navigator, but N2011022320 still has a broken editor.  I have now added  globalCommands.js to the compiled eas.js file so the next build should be good.

Comment 2 Andrew Niefer

2011-02-24 16:52:50 EST

I had to make some additional changes to coding.html, I created a new compiled block named coding-editor-container.js, and moved the globalCommands.js out of the eas.js block.

Comment 3 Susan McCourt

2011-02-24 16:59:48 EST

sorry, Andrew.  I knew to be paranoid about new bundles, but didn't realize/remember that the closure.xml had to be updated for script file changes.  I thought it was derived from the file itself.

(Do we have a page on the wiki about what kinds of structural changes matter and what needs to be updated when they are made?)

Comment 4 Andrew Niefer

2011-02-25 14:48:52 EST

(In reply to comment #3)
> sorry, Andrew.  I knew to be paranoid about new bundles, but didn't
> realize/remember that the closure.xml had to be updated for script file
> changes.  I thought it was derived from the file itself.
> 
> (Do we have a page on the wiki about what kinds of structural changes matter
> and what needs to be updated when they are made?)

Don't worry Susan, I forgot about this myself until it stopped working.
I think we will need to come up with a better story here going forward.  Sometime soon I will be attempting to compile dojo, we will see if that experience provides a more manageable way of compiling our own js.

There is no wiki about this currently, I'll put it down on the list of things to do.