Bugzilla – Full Text Bug Listing
| Summary: | Hermes: package naming needs to be refactored. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Eric Gwin <eric.gwin> | ||||||||||||||
| Component: | Eclipselink | Assignee: | Nobody - feel free to take it <nobody> | ||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||
| Severity: | normal | ||||||||||||||||
| Priority: | P3 | CC: | neil.hauge, pascal.filion, peter.krogh, shaun.smith | ||||||||||||||
| Version: | unspecified | Flags: | eric.gwin:
indigo+
|
||||||||||||||
| Target Milestone: | --- | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | Windows XP | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Eric Gwin
moving this to JPA since the other relavant bugs were also moved there by Shaun. Created attachment 190329 [details]
Hermes parser
Since the project does not exist, I had to create a zip file. It contains:
- Latest Hermes parser code
- @version and @since have the correct version number
- The code was split into a public API and internal code
Created attachment 190330 [details] Hermes parser tests Same as attachment 190329 [details]. Created attachment 190690 [details]
Moving Hermes parser to new location
This patch contains
- Latest code (more content assist support)
- Deletion of the parser from utils/org.eclipse.persistence.utils.jpa.query
- Addition of the code to jpa/org.eclipse.persistence.jpa.jpql
Created attachment 190692 [details] Moving Hermes parser tests to new location same as attachment 190690 [details] The only issue I have found with the last round of patches is that the test project is now a full plugin project. I think the plan was to keep this as a regular Java project for now to avoid the split package issue, among other potential issues. Agreed, we align the naming with the plug-in style in anticipation of the planned evolution but we don't make the projects plug-in projects at this time. Created attachment 190772 [details]
Made the test project a simple project
This patch is the same as the previous patch except the test project is no longer a plug-in project.
Created attachment 190781 [details]
Moving Hermes parser to new location
This includes changed made between now and the previous patch, which caused unit-tests to fail since the new patch for the test included the latest.
The latest round of patches for this bug have been reviewed and committed. The parser and test project are now in trunk/jpa. The util based projects have been left empty. Eric, let me know if I should do anything special with these. I think the plan is that I would simply delete them. The new jpa.jpql project is the key to the Dali dependency here, so please integrate this into the build and published content as soon as it is reasonable to do so. Thanks. . Bug was incorrectly set to iplog. Patch should have been set instead. Fixed The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink |