Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 338039

Summary:	new Ant 1.8 creates different "created by" value
Product:	[WebTools] WTP Releng	Reporter:	David Williams <david_williams>
Component:	releng	Assignee:	David Williams <david_williams>
Status:	RESOLVED FIXED	QA Contact:	David Williams <david_williams>
Severity:	normal
Priority:	P3
Version:	3.10
Target Milestone:	3.10.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description David Williams

2011-02-23 21:20:37 EST

Just to document it, 

After we've moved to Ant 1.8, there were many "comparator" errors, pointing out that "Created-by" field in manifest.mf files had "unexpectedly" changed. 

This only effects bundles with "nested" jars ... seems to impact a lot of test bundles ... not that many of the regular code bundles, since most of those we have "flattened" into bundle root. 

Previous, these manifest.mf files started with

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.7.1
Created-By: 2.3 (IBM Corporation)

(and, the "2.3" seems odd to begin with, so guess 1.8 really did fix something.) 

So now with Ant 1.8.2, these manifests begin with 

Manifest-Version: 1.0
Ant-Version: Apache Ant 1.8.2
Created-By: pxi32dev-20100813 (SR12 FP1 ) (IBM Corporation)

A better message.

Comment 1 David Williams

2011-02-23 21:24:46 EST

It is not worth re-tagging bundles to pick up this change (though, a better message) 

I have improved our "filter" in releng tests to omit warnings that have
this warning message: 

The manifest header "Created-By" has different values.

Comment 2 David Williams

2011-02-23 21:25:38 EST

fixed for this week's I build

Comment 3 David Williams

2011-02-24 10:05:09 EST

Guess I messed up reg ex expression ... still shows up, not filtered out. I'll have to test locally.

Comment 4 David Williams

2011-02-24 10:36:55 EST

reg ex is ok, but this message follows an unexpected format. There are two "differences found" lines which throws off our expected data structure, so the "reason" ends up in "extra data" instead of 'reason'. 


I'll have to investigate how to fix (but, more than fixing property file) ... need more sophisticated parsing of log to begin with. 




       canonical: osgi.bundle,org.eclipse.jst.server.generic.jonas,1.5.205.v200805140145
              Difference found for canonical: osgi.bundle,org.eclipse.jst.server.generic.jonas,1.5.205.v200805140145 between file:/home/data/httpd/download.eclipse.org/webtools/downloads/drops/R3.3.0/S-3.3.0M2-20100923155521/repository/ and file:/shared/webtools/projects/wtp-R3.3.0-I/workdir/I-3.3.0-20110224081621/buildrepository/jst-sdk
                     Difference found for canonical: osgi.bundle,org.eclipse.jst.server.generic.jonas,1.5.205.v200805140145 between file:/home/data/httpd/download.eclipse.org/webtools/downloads/drops/R3.3.0/S-3.3.0M2-20100923155521/repository/ and file:/shared/webtools/projects/wtp-R3.3.0-I/workdir/I-3.3.0-20110224081621/buildrepository/jst-sdk
                            The manifest header "Created-By" has different values.

Comment 5 David Williams

2011-02-26 01:43:44 EST

I've released a quick hack for now, just to ignore the extra "differences" line, so the rest of the comparator filter works as expected. 

I'll leave open for a while, to remind me to put in a more proper fix if I can find the time.

Comment 6 David Williams

2011-03-01 02:34:14 EST

Two errors made this hard to diagnose. First was the "differences" lines. But then I had it working in local tests, but still didn't work in the build. Turned out, there is a "comparator.properties" file in releng (so, could differ by stream) which I forgot about ... I was just changing/testing the one in the test bundle itself, which is there to serve as default.