Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337979

Summary: [ui] max/restore the editor area and viewstack tabs disappear
Product: [Eclipse Project] Platform Reporter: Paul Webster <pwebster>
Component: SWTAssignee: Bogdan Gheorghe <gheorghe>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: dean.t.roberts, emoffatt, gheorghe, remy.suen
Version: 4.1   
Target Milestone: 4.2 M7   
Hardware: PC   
OS: Linux-GTK   
Whiteboard:
Attachments:
Description Flags
No tabs on view stacks none

Description Paul Webster CLA 2011-02-23 10:05:18 EST 
Created attachment 189600 [details]
No tabs on view stacks

I have I20110218-0831

I maximize the editor area to look through a compare editor, and then restore the editor area.

All of the view stacks no longer show tabs.

PW
Comment 1 Paul Webster CLA 2012-02-24 09:27:10 EST 
I just tested this, and it's still a problem on I20120223-2200

PW
Comment 2 Remy Suen CLA 2012-02-24 09:29:07 EST 
This feels like an SWT problem to me though.

Paul, does the error occur with the Classic theme?
Comment 3 Remy Suen CLA 2012-02-24 09:31:25 EST 
(In reply to comment #2)
> This feels like an SWT problem to me though.

Sending it over there. I cannot reproduce it on Windows 7.

I opened a compare editor via the 'Git Staging' view, hit Ctrl+M, Ctrl+M again, nothing weird happened in the 'Classic' or the 'Windows 7' theme.
Comment 4 Paul Webster CLA 2012-02-24 09:33:23 EST 
Yes, it occurs in the classic theme for me as well, using the mouse or CTRL+M twice.

PW
Comment 5 Paul Webster CLA 2012-02-24 09:52:59 EST 
This was re-introduced in I20120222-2200

+ Bug 186404 - [Viewers] Update PatternFilter API to allow extensions (FIXED)
+ Bug 325543 - &apos;endof&apos; option in locationURI for menuContributions behaves incorrectly (FIXED)
+ Bug 340695 - Can&apos;t reposition trim elements (NEW)
+ Bug 372077 - Context debug view not plumbed in properly (FIXED)
+ Bug 372226 - Installed CSS editor and Appearance page contains blank area (FIXED)
+ Bug 372240 - [Compatibility] Ctrl+W closes a non-active editor (FIXED)


PW
Comment 6 Remy Suen CLA 2012-02-24 09:55:47 EST 
(In reply to comment #5)
> This was re-introduced in I20120222-2200

Try turning off Cairo? Or is your GTK+ version not high enough anyway?
http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8556eb3af19a4c2e95b83b815025bc4d31605115
Comment 7 Paul Webster CLA 2012-02-24 10:12:13 EST 
Because of the 3.8 build problems, we have the same SWT in all 3 builds:

I20120221-2200/eclipse/plugins/org.eclipse.swt.gtk.linux.x86_64_3.8.0.v3821b.jar
I20120222-2200/eclipse/plugins/org.eclipse.swt.gtk.linux.x86_64_3.8.0.v3821b.jar
I20120223-2200/eclipse/plugins/org.eclipse.swt.gtk.linux.x86_64_3.8.0.v3821b.jar

I'm still on 2.18, so usecairo is still false.

PW
Comment 8 Bogdan Gheorghe CLA 2012-02-24 10:29:14 EST 
I'm able to reproduce this on my Ubuntu 11.10 which has the latest GTK 2. Investigating...
Comment 9 Bogdan Gheorghe CLA 2012-02-24 16:56:06 EST 
The bug caused by changes in the StackRenderer that went in this week but the real bug was in the GTK reparent code. In a nutshell, we were not putting the size of the control back once it was reparented.

Fixed > 20120224.