Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337926

Summary:

CompletionCombo: selection events are not fired in all cases

Product:

[RT] Riena

Reporter:

Elias Volanakis <elias>

Component:

Assignee:

Elias Volanakis <elias>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

unspecified

Target Milestone:

3.0.0

Hardware:

OS:

Windows Vista

Whiteboard:

Attachments:

Description	Flags
Snippet	none
Patch v1	none
Updated patch	none

Description Elias Volanakis

2011-02-22 20:55:46 EST

In some cases the CompletionCombo does not fire selection events -- where the original CCombo would fire them.

- text match in the text field
- text match pasted into the text field
- text match from the list

Also we should consider these cases:

- text edited in the text field, no match
- text edited in the text field, new match
- text cleared in the text field 
- text cleared via cut operation in the text field 
- text set via API (setter)

Comment 1 Elias Volanakis

2011-02-22 21:04:15 EST

Created attachment 189565 [details]
Snippet

Comment 2 Elias Volanakis

2011-02-22 21:04:43 EST

Created attachment 189566 [details]
Patch v1

Comment 3 Elias Volanakis

2011-02-28 17:56:02 EST

Patch was doing to much. Committed different version.

Essentially: 

- user interaction triggers selection events. This means: klicking on the list, using arrows on the list or text, using mouse wheel on the list or text, typing in the text field (if a new item is selected as a result, or the selection is cleared because no match), deleting the text (=empy = no match)
- API interaction does not cause selection events. I.e. select(...), deselect(...), deselectAll(). This is consistent with what SWT does and prevents stack-overflows when listeners invoke such API.

Comment 4 Elias Volanakis

2011-02-28 17:57:22 EST

Created attachment 190007 [details]
Updated patch

Comment 5 Elias Volanakis

2011-02-28 17:58:24 EST

Resolved