Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337891

Summary: [TMF] Event clone erases content
Product: z_Archived Reporter: Patrick Tasse <patrick.tasse>
Component: LinuxToolsAssignee: Francois Chouinard <fchouinard>
Status: CLOSED FIXED QA Contact: Francois Chouinard <fchouinard>
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Proposed patch in org.eclipse.linuxtools.tmf fchouinard: iplog+

Description Patrick Tasse CLA 2011-02-22 15:04:34 EST
Build Identifier: 

Cloning an event produces an event with null source, reference, content and fields. This was done because a proper deep clone of Object data members of unknown type was not possible.

The proposed patch performs a shallow copy of these data members, which is not a proper clone either, but works as long as the data is not modified.

This should be revisited to find a correct solution.

Reproducible: Always
Comment 1 Patrick Tasse CLA 2011-02-22 15:07:18 EST
Created attachment 189538 [details]
Proposed patch in org.eclipse.linuxtools.tmf

Legal Message: I, Patrick Tasse, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer to make this contribution under
the EPL.
Comment 2 Francois Chouinard CLA 2011-03-29 18:27:34 EDT
Patch committed. Thanks Patrick.
Comment 3 Francois Chouinard CLA 2011-07-22 15:01:47 EDT
Delivered with 0.8