Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337865

Summary:

"No-interface" should be renamed to "No-interface View" on the "Create EJB 3.x Session Bean" dialog box

Product:

[WebTools] WTP EJB Tools

Reporter:

Diego Sahagun <diegosr>

Component:

jst.ejb

Assignee:

Carl Anderson <ccc>

Status:

RESOLVED FIXED

QA Contact:

Kaloyan Raev <kaloyan>

Severity:

trivial

Priority:

CC:

cbridgha, katep, lovering, shr31223

Version:

unspecified

Flags:

kaloyan: review+

Target Milestone:

3.4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
proposed patch for this bug	none
Making a change to the documentation to reflect the change in the GUI page	none
Replacement for the previous patch I submitted	none
I am making changes to the sessbwiz.html topic	none
Wizard's label change	ccc: iplog+

Description Diego Sahagun

2011-02-22 12:22:57 EST

Build Identifier: 3.6.2.r362_v20110131

"No-interface" should be renamed to "No-interface View" on the "Create EJB 3.x Session Bean" dialog box to match what it is called in the EJB 3.1 specification.

Reproducible: Always

Steps to Reproduce:
1.Open the EJB 3.x session bean wizard, the option "No-interface" is there.

Comment 1 Diego Sahagun

2011-02-22 12:24:54 EST

Created attachment 189517 [details]
proposed patch for this bug

Comment 2 Chuck Bridgham

2011-02-22 12:53:12 EST

Hi Diego, 


Because this is EJB - it should go to EJB project, and be reviewed by Kaloyan

Comment 3 Kaloyan Raev

2011-02-25 11:39:23 EST

I am not sure why this change makes sense. 

Labeling the checkbox with the short "No-interface" is as complete as the "Local" and "Remote" checkboxes.

But, if you feel it is important, I am fine with it. Just add to the patch a correction in the context help - the one that appears when clicking the question mark button on the bottom left side of the wizard. There "No-interface" is stated too. It needs to be corrected there too.

Comment 4 Virginia Lovering

2011-03-30 12:07:09 EDT

I have updated the documentation to reflect this change.

Comment 5 Virginia Lovering

2011-03-30 12:09:08 EDT

Created attachment 192206 [details]
Making a change to the documentation to reflect the change in the GUI page

Comment 6 Virginia Lovering

2011-03-30 17:29:22 EDT

Created attachment 192231 [details]
Replacement for the previous patch I submitted

Comment 7 Kate Price

2011-03-30 17:47:20 EDT

Doc change applied and released to build March 30.

Comment 8 Kaloyan Raev

2011-05-13 10:26:57 EDT

Kate, we don't have 3.2 maintenance branch for the ejb.doc.user plugin. So your change went in both 3.2 and 3.3 branches. I just want to make sure that this was your intention. 

Can you confirm this?

How about the change in the wizard's label? Is it targeted only for 3.3?

Comment 9 Kate Price

2011-05-13 10:55:05 EDT

Yes - I intended the changes to go into the 3.3 and 3.2 maintenance streams. Normally the dev teams branch the doc plugins while they're doing the code plugins, so I assumed that's what had been done and released against the 3.2M releng files. Apologies for the mess.

Comment 10 Kaloyan Raev

2011-05-17 08:53:52 EDT

I created a R3_2_maintenance branch for the doc plugins. It's rooted at the latest state of HEAD. 

Thanks, Kate. I am not sure what has been actually released to build. I don't see any changes in the context help of the Session Bean wizard. This is good, because the initial patch for changing the label in the wizard has not been committed yet.  

I am re-targeting this patch to M1 of the next release.

Comment 11 Kaloyan Raev

2011-07-13 12:59:05 EDT

As discussed by mail, I am assigning this bug to Carl. 
Carl, please update the severity, priority and target fields, so the bug reflects the actual importance.

Comment 12 Virginia Lovering

2011-10-06 13:10:39 EDT

Created attachment 204698 [details]
I am making changes to the sessbwiz.html topic

I am making changes to the sessbwiz.html topic

Comment 13 Diego Sahagun

2011-12-06 18:08:58 EST

Created attachment 208032 [details]
Wizard's label change

Comment 14 Diego Sahagun

2011-12-06 18:22:13 EST

Added patch "Wizard's label change" with a slight variation than the previous.
Kaloyan please review so Carl can commit the patch.

Comment 15 Kaloyan Raev

2011-12-07 02:20:40 EST

Thanks, Diego. Please go ahead.

Comment 16 Diego Sahagun

2011-12-07 12:17:50 EST

Thanks Kaloyan,

Carl will commit patch "Wizard's label change" after next Tuesday Dec. 13th due to  shutdown for 3.4.0 M4.

Comment 17 Carl Anderson

2011-12-13 17:56:30 EST

Committed to HEAD for WTP 3.4.0 M5