Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337848

Summary: Change prefix value - undo/redo broken
Product: z_Archived Reporter: Stanislav Nichev <stanislav.nichev>
Component: WTP IncubatorAssignee: Dimitar Tenev <dimitar.tenev>
Status: CLOSED FIXED QA Contact: Dimitar Tenev <dimitar.tenev>
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Attachments:
Description Flags
reproduce data
none
reproduce data none

Description Stanislav Nichev CLA 2011-02-22 10:28:40 EST
Build Identifier: 

Hi Colleagues,                                                           
                                                                         
In SIE 731 the following scenario fails:                                 
1) Open the attached WSDL in the SIE                                     
2) Go to the source tab                                                  
3) Go to the xmlns:tns prefix of the definition and update its value     
4) Go to the DT tab                                                      
5) 70+ errors on the WSDL elements shown in the title bar                
6) Ctrl + Z                                                              
                                                                         
Nothing happens. Execute Ctrl + Z / Ctrl + Y. Each time you execute      
undo, the operation history is updated with "typing".                    
                                                                         
As a hint on the cause: The AttributeReconcileAdapter #                  
processAttributeStartingWithXMLNS is updaing the DOM and is changing the 
DOM.                                                                     
Generally - the adapters should not update the DOM, only the EMF model.  
                                                                         
Regards,                                                                 
Stanislav                                                                
                                                                         
    Memo                                                                 
    16.11.2010 10:56:13      Tzvetan Gaydev                              
Hi colleagues,                                                           
                                                                         
The scenario below may be is related to this issue.                      
                                                                         
1.)Open attachedWSDL with name ProductProvider.wsdl                      
2.)Add operation to existed PortType                                     
3.)Rename first operation, i.e. "listByCondition". As a result you will  
see that 2 errors occurred                                               
The errors are caused by inconsistency between DOM and WSDL model, i.e.  
The types of the parts in the first operation does not have DOM element, 
if you try to get it throught WTP WSDL model API.                        
4.)Remove the new added operation                                        
5.)Remove the automaticaly added schema                                  
6.)As a result there is no errors and all is fine                        
                                                                         
Regards,                                                                 
Tsvetan Gaydev                                                           
                                                                         
    Memo                                                                 
    30.11.2010 10:53:01      Stanislav Nichev                            
Hi Colleagues,                                                           
                                                                         
Fix has been submitted.                                                  
Code review by Dimitar Tenev.                                            
                                                                         
Regards,                                                                 
Stanislav                                                                


                                                                          
    Memo                                                                  
    03.12.2010 13:08:11      Nevena Manova                                
Hi,                                                                       
I tested this fix but I found an issue.                                   
                                                                          
The first scenario is ok but the second one fails.                        
Every time I rename the first operation, its input and oputput parameter  
are marked with an error marker, saying:                                  
                                                                          
The part 'parameters' has an invalid value 'ConditionParameter' defined   
for its element. Element declarations must refer to valid values defined  
in a schema.,,ProductProvider.wsdl,,/                                     
                                                                          
If I go to the source tab and then back to the SI tab, the errors         
disappear.                                                                
                                                                          
Regards,                                                                  
Nevena                                                                    


Reproducible: Always
Comment 1 Stanislav Nichev CLA 2011-02-22 10:29:49 EST
Created attachment 189500 [details]
reproduce data
Comment 2 Stanislav Nichev CLA 2011-02-22 10:30:16 EST
Created attachment 189501 [details]
reproduce data
Comment 3 Stanislav Nichev CLA 2011-07-28 15:49:37 EDT
Hi Guys,

Testing this issue in Indigo, I cannot reproduce it. It seems that it has been fixed by some other fix.

Regards,
Stanislav
Comment 4 Dimitar Tenev CLA 2011-08-26 08:17:17 EDT
Hi Colleagues,

I can not reproduce these issues on Eclipse 3.5.2, so I am closing the bug.

Best regards,
Dimitar
Comment 5 Dimitar Tenev CLA 2011-08-26 08:18:00 EDT
I am closing the issue.