Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337791

Summary:	[menu] Command name Debug/Run Last Launched not accurate
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	Debug	Assignee:	Michael Rennie <Michael_Rennie>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	hello, Michael_Rennie, pawel.1.piech, remy.suen
Version:	3.3
Target Milestone:	3.8 M6
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2011-02-22 02:27:34 EST

At the beginning the command names Debug/Run Last Launched was correct but when the option got added (on by default) to launch based on the current selection, this became wrong unless one changes the preference back to 'Always launch the previously launched application'. Currently, out of the box those commands no longer launch the previous application.

Possible solutions:
- introduce separate commands
- change the names (and descriptions) to e.g.
  Run Last Launched -> Launch
  Debug Last Launched - > Launch in Debug Mode
  and: point to the preference in the description

Comment 1 Pawel Piech

2011-02-22 12:16:54 EST

I remember a debate Darin had about this action when he introduced context launching (see Bug 186527).  But caution prevailed. I would vote to rename them as:

Run Last Launched -> Run
Debug Last Launched -> Debug

Run/Debug are names used in other items in the same (as opposed to "Launch") and their vagueness should invite the user to look at the action help to understand it.

Comment 2 Michael Rennie

2011-02-22 14:56:04 EST

(In reply to comment #1)
> Run Last Launched -> Run
> Debug Last Launched -> Debug
> 
> Run/Debug are names used in other items in the same (as opposed to "Launch")
> and their vagueness should invite the user to look at the action help to
> understand it.

I agree, if we rename the commands it should be to 'Run' and 'Debug', 'Launch' is a little too vague.

I am curious though, where the commands show up using the 'Run Last Launched' ('Debug Last Launched') labels when context launching is enabled? A quick inspection shows the commands properly renamed as 'Run' ('Debug') in the Run menu and the keys preference page. Or is this more of a consistency idea since the binding on the keys page always shows up as 'Run' ('Debug') we should always show it on the Run menu as such as well?

Comment 3 Dani Megert

2011-02-23 03:05:06 EST

> I agree, if we rename the commands it should be to 'Run' and 'Debug'
I'm fine with those names.

>, 'Launch' is a little too vague.
What about the "Launching" preference page then? ;-).

> I am curious though, where the commands show up using the 'Run Last Launched'
> ('Debug Last Launched') labels when context launching is enabled?
1. start Eclipse with a new workspace
2. open 'Run' main menu
At this point Debug is not yet loaded and hence the command labels are used. Next time you open the menu the label will be correct (according to the preference).

Comment 4 Michael Rennie

2011-02-23 12:24:08 EST

(In reply to comment #3)

> >, 'Launch' is a little too vague.
> What about the "Launching" preference page then? ;-).

We already had a Run/Debug page and were 'forced' to pick Launching :)

Comment 5 Michael Rennie

2011-05-13 10:03:02 EDT

*** Bug 345683 has been marked as a duplicate of this bug. ***

Comment 6 Michael Rennie

2012-02-29 16:15:03 EST

Pushed fix to rename the action / command to Run / Debug.

The downside of this change in 4.2 is that the names / description of the commands do not properly update when the preference is changed. The reason for this is the same as the underlying problem for bug 317182 (the actions are not properly reporting they have changed to the model + renderer on the platform UI side)

fix pushed to:

http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=3d89e94ffcffc2d71c03a1001b7baab6de614635

Comment 7 Dani Megert

2012-03-02 05:45:18 EST

Looks good!