Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337735

Summary:

Remove workarounds for Ant builder bug in Jar in Jar Loader

Product:

[Eclipse Project] JDT

Reporter:

Markus Keller <markus.kell.r>

Component:

Assignee:

Markus Keller <markus.kell.r>

Status:

RESOLVED FIXED

QA Contact:

Severity:

trivial

Priority:

CC:

daniel_megert, deepakazad, raksha.vasisht, rthakkar

Version:

3.7

Target Milestone:

3.7 M6

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Fix	none
Fix 2	none

Description Markus Keller

2011-02-21 11:12:24 EST

Created attachment 189420 [details]
Fix

Remove workarounds for Ant builder bug in Jar in Jar Loader

Comment 1 Markus Keller

2011-02-21 14:15:29 EST

Created attachment 189436 [details]
Fix 2

I've released the first patch, but then I saw that this causes the Jar to be rebuilt after clean. That's not what we want. We need to keep the empty "After a Clean" task. I've updated the comment in build_jar-in-jar-loader.xml.

Comment 2 Markus Keller

2011-02-21 14:20:32 EST

Fixed in HEAD.

JDT/UI Team: Please ignore any outgoing changes in
    /org.eclipse.jdt.ui/jar-in-jar-loader.zip
that could show up in your workspace if you updated to the first fix.

Comment 3 Markus Keller

2012-01-25 13:37:38 EST

The workarounds were for bug 114563.

Comment 4 Dani Megert

2012-01-25 15:43:08 EST

(In reply to comment #3)
> The workarounds were for bug 114563.

So, they can be removed now?

Comment 5 Markus Keller

2012-01-27 14:37:20 EST

(In reply to comment #4)
> (In reply to comment #3)
> > The workarounds were for bug 114563.
> 
> So, they can be removed now?

No. The workarounds were initially to avoid bug 114563, but when I wanted to remove them, I found that the dummy clean target is still necessary, see comment 2. The workaround has morphed into the proper fix, and I've documented that in build_jar-in-jar-loader.xml.

Bug 335999 updated the doc to explain the 4 build targets.