Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337729

Summary: Undo of change def tns breaks bindings
Product: z_Archived Reporter: Stanislav Nichev <stanislav.nichev>
Component: WTP IncubatorAssignee: Dimitar Tenev <dimitar.tenev>
Status: CLOSED FIXED QA Contact: Dimitar Tenev <dimitar.tenev>
Severity: major    
Priority: P3 CC: dimitar.donchev, stanislav.nichev
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Attachments:
Description Flags
updating ModelReconciler to fix the bindings :)
none
Patch updating the WSDL model reconciler + test none

Description Stanislav Nichev CLA 2011-02-21 10:03:51 EST
Build Identifier: 

Hi Colleagues,
                                                                                
In SIE 731 the following scenario fails:                                         
1) Create new WSDL with bindings 
2) Open it in the SIE 
3) Change the definition tns
4) Ctrl+Z
 
A warning message is shown in the title.
       
Cause: During the undo of the operation, the binding port type needs to be updated. However - in the eBinding instance, the ePortType is null.           
It needs to be reconciled - eBinding.setEPortType(ePortType) method 
must be called.                                              
BUT: This method call updates the DOM, thus breaking any subsequent undo/redo operations. Another solution of the problem needs to be found.         

Regards,                                                                        Stanislav                                                                      

Reproducible: Always
Comment 1 Stanislav Nichev CLA 2011-03-16 03:48:48 EDT
Created attachment 191281 [details]
updating ModelReconciler to fix the bindings :)

Hi Colleagues,

Attaching fix. Unit tests still needs to be developed or existing one should be updated.

Regards,
Stanislav
Comment 2 Stanislav Nichev CLA 2011-07-28 15:00:30 EDT
Created attachment 200550 [details]
Patch updating the WSDL model reconciler + test

Hi Guys,

I've prepared a new patch, including a test. The test should make sure no regressions are introduced.

Regards,
Stanislav
Comment 3 Stanislav Nichev CLA 2011-08-13 13:29:22 EDT
Hi Guys,

I'm setting priority to major, since the issue is with high visibility and is reproducible every time when there are bindings in the WSDL document.

Regards,
Stanislav
Comment 4 Dimitar Tenev CLA 2011-08-26 08:26:20 EDT
Thanks Stani,

I have retested, and applied the fix.

Best regards,
Dimitar