Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337723

Summary: No validation on imported schemas performed on editor start/open
Product: z_Archived Reporter: Stanislav Nichev <stanislav.nichev>
Component: WTP IncubatorAssignee: Dimitar Tenev <dimitar.tenev>
Status: NEW --- QA Contact: Dimitar Tenev <dimitar.tenev>
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows Vista   
Whiteboard:
Attachments:
Description Flags
a sample archive for reproduction
none
patch fixing the batch validation of contained schemas
none
test and test data covering the fix none

Description Stanislav Nichev CLA 2011-02-21 09:33:44 EST
Build Identifier: 

Hi Colleagues,

When undoing/redoing an "add namespace" command, validation errors are shown. I'll attach a sample archive.

Reproducible: Always

Steps to Reproduce:
1.Open a WSDL, importing several extenal XML Schema files
2.Add new namespace
3.Execute undo
4.Validation errors shown
Comment 1 Stanislav Nichev CLA 2011-02-21 09:40:38 EST
Created attachment 189410 [details]
a sample archive for reproduction

Hi Colleagues,

To reproduce with the given archive, execute the following steps:
1) Copy the attached files into the workspace
2) Open the attached WSDL in the SIE
3) Go to the DT tab
4) Add new namespace
5) No validation errors should be shown
6) Execute undo - 17 validation errors shown

In some cases, executing redo is clearing the validation errors. 
It seams that the validation errors are for the imported schemas. 

Regards,
Stanislav
Comment 2 Stanislav Nichev CLA 2011-02-22 07:06:31 EST
Hi Colleagues,

An update on the issue:

The validation errors are correctly displayed. The wsdl in the test scenario is importing two identical schemas (different filenames). 

The only bug here - no validation errors are shown when the wsdl is initially opened. 
No namespace needs to be created - creating new service interface works just as fine.

The live validation should be started on editor start as well.

I'm updating the issue summary.

Regards,
Stanislav
Comment 3 Stanislav Nichev CLA 2011-02-22 08:19:18 EST
Created attachment 189483 [details]
patch fixing the batch validation of contained schemas
Comment 4 Stanislav Nichev CLA 2011-02-22 08:22:59 EST
Created attachment 189484 [details]
test and test data covering the fix

Adding test covering the proposed fix. The test data needs to be placed under <test plugin>/data/pub/csns/17errors

Regards,
Stanislav