Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337660

Summary: Empty Commits, old mode 100644 new mode 100755 issue?
Product: [Technology] EGit Reporter: Marcel Bruch <marcel.bruch>
Component: CoreAssignee: Project Inbox <egit.core-inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: major    
Priority: P3 CC: christian.halstrick
Version: 0.11   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Marcel Bruch CLA 2011-02-20 05:23:59 EST
I'm experiencing a strange behavior in EGit during commit.

I modified a resource and committed per EGit UI. But after commit the resources stays in "modified state" (indicated by the star on the lower right corner). Repeatedly committing this resource doesn't fix this. Worse, this change now shows up in all subsequent commits. 

Looking at the logs I could see that Egit actually made an empty commit each time:

First commit with EGit:

Holzfisch:org.eclipse.recommenders Marcel$ git show 1d07a5626dde6e08f3c93d79f7af1a39b8d923dd
commit 1d07a5626dde6e08f3c93d79f7af1a39b8d923dd
Author: Marcel Bruch <bruch@st.informatik.tu-darmstadt.de>
Date:   Sun Feb 20 10:43:23 2011 +0100

    fixed https://bugs.eclipse.org/bugs/show_bug.cgi?id=337299

diff --git a/org.eclipse.recommenders.rcp/src/org/eclipse/recommenders/internal/rcp/RecommendersNatureToggleAction.java 
old mode 100755
new mode 100644
index cbe5d24..a206e34
--- 
<removed content>
@@ -10,68 +10,79 @@
$

Resource stays in changed mode.
Second commit with EGit:

$ git show 233255ceb6e118c77fa93befe76909b4ae3399f4
commit 233255ceb6e118c77fa93befe76909b4ae3399f4
Author: Marcel Bruch <bruch@st.informatik.tu-darmstadt.de>
Date:   Sun Feb 20 10:52:36 2011 +0100

    committed again? Egit bug?
$


Third commit: After committing per command line, the commit looks as follows:

$ git show f899bc78a3ee07f176ec3c53c016dd6a366af31c
commit f899bc78a3ee07f176ec3c53c016dd6a366af31c
Author: Marcel Bruch <bruch@st.informatik.tu-darmstadt.de>
Date:   Sun Feb 20 10:53:15 2011 +0100

    egit bug from command line?

diff --git a/org.eclipse.recommenders.rcp/src/org/eclipse/recommenders/internal/rcp/RecommendersNatureToggleAction.java 
old mode 100644
new mode 100755
$

and the "changed" marker in EGit are all gone. I can't reproduce this more exactly because most of the time commits just works.
Comment 1 Christian Halstrick CLA 2011-02-21 07:53:16 EST
please try with the latest nightly build. I think this is fixed. I think this is the same issue as 307560 which was fixed now.

*** This bug has been marked as a duplicate of bug 307560 ***