Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337620

Summary:	compilation problems not noticed by build scripts
Product:	[WebTools] WTP Releng	Reporter:	David Williams <david_williams>
Component:	releng	Assignee:	webtools.releng <webtools.releng-inbox>
Status:	ASSIGNED ---	QA Contact:	Carl Anderson <ccc>
Severity:	normal
Priority:	P3
Version:	3.10
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description David Williams

2011-02-18 17:43:41 EST

In a build during the week, there was once a compile problem, but the build and unit tests kept running ... but, they are supposed to stop. 

I think behavior changed in latest pde builder/compiler. 

We have been simply detecting a file created be pde build (or, jdt?) named "compilation.problem" in a plugins complile log folder. That's either changed names, or no longer created. 

We may have to scan all the @dot.xml files specifically for "error" attributes in the compile log; similar to 
<problems errors="1" problems="1" warnings="0">
	<problem categoryID="50" charEnd="22579" charStart="22566" id="UndefinedMethod" line="957" problemID="67108964" severity="ERROR">
	 <message value="The method getTextContent() is undefined for the type Node"/>
	 <source_context sourceEnd="33" sourceStart="20" value="String text = child.getTextContent();"/>
		 <arguments>
			 <argument value="org.w3c.dom.Node"/>
			 <argument value="getTextContent"/>
			 <argument value=""/>
		 </arguments>
	</problem>
</problems>

Comment 1 David Williams

2011-03-10 14:02:55 EST

I've captured another data point. New hypothesis is the "compilation.problem" file may only be created for bundles that do not have classes in jars. 

Latest failure to catch a compile problem was in M build (old compiler, old pde builder) in the 
org.eclipse.wst.server.ui.tests 
bundle. I noticed it does not have @dot.xml files, but instead logs compiler output in the old-fashioned temp.folder/tests.jar.bin.xml (presumably, since it is creating a "test.jar" instead of putting classes at the root of the bundle. 

So, if we do search for severity="ERROR" then we'd have to search xml files in temp.folder (as well, or, in addition to looking for 'compilation.problem' file).  

That's temp.folder is in the 
${builddirectory}plugins/org.eclipse.wst.server.ui.tests

Comment 2 David Williams

2011-09-21 12:38:03 EDT

mass change back to default assignee and qa contact. I'm not saying I won't work on some :) ... but, won't be all ... so, I think defaults would be best to start over.