Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337579

Summary:	[UI] Update model before API freeze
Product:	[Eclipse Project] e4	Reporter:	Eric Moffatt <emoffatt>
Component:	UI	Assignee:	Project Inbox <e4.ui-inbox>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel, tom.schindl
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug
Bug Depends on:
Bug Blocks:	324957

Description Eric Moffatt

2011-02-18 10:52:49 EST

We need to add a few things to complete the UI model before the API freezes at M6.

- Add a 'closable' attribute to MPlaceholder. Placeholders are generally used to refer to MParts shared between perspectives. We have scenarios where a part in one perspective is closable but in a different one it is not closable...

- Add two new general-use attributes to MApplication:

   - 'transientData': This is a *transient* String -> Object map which clients can use to store any runtime data they want. This should be used to replace the current transient variables in our model (UIElement's 'widget' and 'renderer' fields...).

   - 'clonableSnippets': This allows the storage of reusable model snippets that can subsequently be cloned and added into the presentation. An example of where this will be used is supporting the 'Save As' operation for Perspectives. We would clone the existing perspective and add it to the snippets using the perspectives id. Then we would use the snippet to instantiate the perspective when it's opened (or 'reset').

Comment 1 Eric Moffatt

2011-02-18 13:55:04 EST

Committed in >20110218. Added the new attributes. Tom, could you please review the changes to make sure they're what we expect ?

Adding M6 as the milestone to refactor the code to use the new functionality:

- Fix the stack renderer (and ModeledPageLayout) to use the new 'closeable' field in MPlaceholder.

- Remove 'widget' and 'renderer' as fields once their usage has been moved over to the 'transientData' map.

- Add new snippet methods to the EModelService:

void addSnippet(MApplicationElement root, String snippetId)
   - Clone 'root' (don't include elements referenced through placeholders)
   - change its elementId to 'snipperId'
   - add the clone to the snippets list

void removeSnippet(String snippetId)
   - remove the snippet

MApplicationElement cloneSnippet(String snippetId, String asId)
   - Find and clone the snippet
   - Change its elementId to 'asId' if it's non-null
   - Return the newly cloned snippet

Comment 2 Thomas Schindl

2011-02-18 17:35:42 EST

(In reply to comment #1)
> Committed in >20110218. Added the new attributes. Tom, could you please review
> the changes to make sure they're what we expect ?
> 

On the first short look they are good. I'll integrate the new attributes in the model tooling

Comment 3 Thomas Schindl

2011-03-08 10:45:35 EST

FYI there was a typo in the transient (misspelled as tranient) and i checked in a corected version

Comment 4 Eclipse Genie

2019-06-13 11:48:35 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 5 Lars Vogel

2019-06-13 12:00:08 EDT

API freeze is long gone