Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337554

Summary: [disassembly][breakpoints] Method breakpoints are not shown in the disassembly view
Product: [Tools] CDT Reporter: Marc Khouzam <marc.khouzam>
Component: cdt-debug-dsfAssignee: Project Inbox <cdt-debug-dsf-inbox>
Status: NEW --- QA Contact: Jonah Graham <jonah>
Severity: normal    
Priority: P3 CC: aleherb+eclipse, cdtdoug, nobody, pchuong
Version: 8.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Marc Khouzam CLA 2011-02-18 06:31:05 EST
When setting a method breakpoint in the editor, it is not shown in the disassembly view.

I didn't fully debug, but BreakpointsAnnotationModel#addBreakpointAnnotation() does not set the breakpoint.
Comment 1 Marc Khouzam CLA 2011-02-18 06:32:23 EST
Toni, I wondered if you knew if this was a known issue?  Is it a bug or is it something we can't do?
Comment 2 Anton Leherbauer CLA 2011-02-18 07:05:01 EST
The reason seems to be that the source line of the method breakpoint is not part of the disassembly model.
We could try and associate a method breakpoint with a function label.
Comment 3 Anton Leherbauer CLA 2011-02-18 07:17:14 EST
Actually, in some cases the function header is displayed in the disassembly and so is an associated function breakpoint, but that depends on the line info from the backend.
Comment 4 Anton Leherbauer CLA 2011-03-11 04:30:29 EST
I have added a fallback in BreakpointsAnnotationModel to find a label for the function/method.  That's not a 100% solution, because e.g. C++ methods might not be found if the label is in mangled form.
Comment 5 CDT Genie CLA 2011-03-11 05:23:42 EST
*** cdt cvs genie on behalf of aleherbau ***
Bug 337554 - [disassembly][breakpoints] Method breakpoints are not shown in the disassembly view

[*] BreakpointsAnnotationModel.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/model/BreakpointsAnnotationModel.java?root=Tools_Project&r1=1.5&r2=1.6