Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337443

Summary:

[client] consolidating login info in the UI

Product:

[ECD] Orion

Reporter:

Susan McCourt <susan>

Component:

Client

Assignee:

Susan McCourt <susan>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

malgorzata.tomczyk, Szymon.Brandys

Version:

0.2

Target Milestone:

0.2

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
screenshot	none

Description Susan McCourt

2011-02-17 09:31:57 EST

Created attachment 189186 [details]
screenshot

See attached screenshot.
We are currently showing the user name and the login time in the banner area of our pages.  This can take up quite a bit of room, more room than the search bar.

Short run:  Can we put the login time in a hover rather than show it in the banner?
Slightly longer run: I'd like to build commands for login/logout and rearrange the login information under a menu. (see bug 334191 comment 5).  In fact, I'd like to have freedom to play around with this without having to touch too much code.  What can we do to get the user display info all in one place?  If you show me where it is, I can convert this stuff to commands and register the commands.  Then I could independently play with the rendering of them (layout, whether they are in a menu, etc.)

Comment 1 Szymon Brandys

2011-02-17 13:28:05 EST

(In reply to comment #0)
> Slightly longer run: I'd like to build commands for login/logout and rearrange
> the login information under a menu. (see bug 334191 comment 5).  In fact, I'd
> like to have freedom to play around with this without having to touch too much
> code.  

Go to org.eclipse.orion.server.authentication.form and authentication.formopenid and find xhrAuth.js. This is where we add these things to the toolbar.

Comment 2 Susan McCourt

2011-02-23 23:45:47 EST

I'll take this because I'm in the process of generating all banner code from one place...

Comment 3 Susan McCourt

2011-02-24 03:58:18 EST

fixed.  (It would be useful if someone more familiar with the code could double check that I covered all the login provider cases, as there is code duplicated across different providers.)

The good news is that I've consolidated everything into utility methods so I should be able to tweak the UI without having to go back and touch the various files again.  I didn't move the login stuff to commands per se, just to a utility method that creates a login menu.  When we get to the point that we want to allow plug-ins to add commands to this menu, I can define it using the command framework.