Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337408

Summary:

Add an action to sort columns by name

Product:

z_Archived

Reporter:

Vincent Lorenzo <vincent.lorenzo>

Component:

EMF-Facet

Assignee:

Patrick Tessier <Patrick.Tessier>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

emft.facet-inbox, gdupe

Version:

unspecified

Flags:

gdupe: indigo+
gdupe: review+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

342603

Bug Blocks:

Attachments:

Description	Flags
Add the interface INatTableWidget2 to sort columns by alphabetical order	none
Add the actions to sort columns by alphabetical order in the toolbar (editor and view)	none
icons for the sort by name actions	Patrick.Tessier: iplog+
Add the interface INatTableWidget2 to sort Columns by alphabetical order	none
Add the actions to sort columns by alphabetical order in the toolbar (editor and view)	none
Add the interface INatTableWidget2 to sort Columns by alphabetical order	Patrick.Tessier: iplog+
Add the actions to sort columns by alphabetical order in the toolbar (editor and view)	Patrick.Tessier: iplog+
add user documentation for the Sort Columns actions	Patrick.Tessier: iplog+, gdupe: review+
the image used to illustrate the Sort Columns Actions	Patrick.Tessier: iplog+, gdupe: review+
Add the tests for Sort Columns By Name (A To Z and Z To A)	none
Refactoring the ColumnComparator	none
Refactoring of the ColumnComparator	gdupe: iplog+, gdupe: review+
Add the tests for Sort Columns By Name (A To Z and Z To A)	gdupe: iplog+, gdupe: review+

Description Vincent Lorenzo

2011-02-17 05:47:57 EST

It could be useful provide a "Sort by Name" action to manage the columns order.

Comment 1 Vincent Lorenzo

2011-03-23 12:49:27 EDT

Created attachment 191768 [details]
Add the interface INatTableWidget2 to sort columns by alphabetical order

Add the interface INatTableWidget2.
Now the widget provides the method to sort the columns using the alphabetical order.

Comment 2 Vincent Lorenzo

2011-03-23 12:51:21 EDT

Created attachment 191769 [details]
Add the actions to sort columns by alphabetical order in the toolbar (editor and view)

Add the actions to sort columns by alphabetical order in the toolbar (editor and view)

(a) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
© I contribute the content under the EPL.

Regards,
Vincent Lorenzo

Comment 3 Vincent Lorenzo

2011-03-23 13:02:24 EDT

Created attachment 191772 [details]
icons for the sort by name actions

(a) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
© I contribute the content under the EPL.

Regards,
Vincent Lorenzo

Comment 4 Gregoire Dupe

2011-03-24 04:47:40 EDT

Hello,

I've created a CQ for this contribution.

Regards,
Gregoire Dupe

Comment 5 Gregoire Dupe

2011-03-25 08:48:17 EDT

CQ URL: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5055

Comment 6 Vincent Lorenzo

2011-03-28 04:40:20 EDT

Created attachment 191981 [details]
Add the interface INatTableWidget2 to sort Columns by alphabetical order

Now the widget provides the method to sort the columns using the alphabetical order.

(a) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.

Comment 7 Vincent Lorenzo

2011-03-28 04:42:10 EDT

Created attachment 191982 [details]
Add the actions to sort columns by alphabetical order in the toolbar (editor and view)

(a) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Comment 8 Vincent Lorenzo

2011-03-28 04:43:11 EDT

Comment on attachment 191982 [details]
Add the actions to sort columns by alphabetical order in the toolbar (editor and view)

Check patch for this contribution!

Comment 9 Vincent Lorenzo

2011-03-28 05:47:00 EDT

Created attachment 191986 [details]
Add the interface INatTableWidget2 to sort Columns by alphabetical order

(a) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Comment 10 Vincent Lorenzo

2011-03-28 05:49:34 EDT

Created attachment 191987 [details]
Add the actions to sort columns by alphabetical order in the toolbar (editor and view)

(a) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.

Comment 11 Gregoire Dupe

2011-03-28 06:03:30 EDT

Comment on attachment 191987 [details]
Add the actions to sort columns by alphabetical order in the toolbar (editor and view)

Vincent, please, can you confirme that you contribute the content under the EPL ?

Comment 12 Vincent Lorenzo

2011-03-28 07:27:14 EDT

(a) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.

Comment 13 Vincent Lorenzo

2011-03-28 07:27:35 EDT

(a) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Comment 14 Patrick Tessier

2011-03-28 07:29:47 EDT

Comment on attachment 191987 [details]
Add the actions to sort columns by alphabetical order in the toolbar (editor and view)

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 459.

Comment 15 Patrick Tessier

2011-03-28 07:30:16 EDT

Comment on attachment 191987 [details]
Add the actions to sort columns by alphabetical order in the toolbar (editor and view)

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 459.

Comment 16 Patrick Tessier

2011-03-28 07:34:18 EDT

Comment on attachment 191772 [details]
icons for the sort by name actions

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 460.

Comment 17 Patrick Tessier

2011-03-28 07:36:36 EDT

Comment on attachment 191986 [details]
Add the interface INatTableWidget2 to sort Columns by alphabetical order

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 461.

Comment 18 Vincent Lorenzo

2011-04-06 11:28:12 EDT

Created attachment 192653 [details]
add user documentation for the Sort Columns actions

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 19 Vincent Lorenzo

2011-04-06 11:29:38 EDT

Created attachment 192654 [details]
the image used to illustrate the Sort Columns Actions

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 20 Gregoire Dupe

2011-04-06 12:00:47 EDT

Comment on attachment 192653 [details]
add user documentation for the Sort Columns actions

Patrick, please, can you commit this patch ?

Comment 21 Gregoire Dupe

2011-04-06 12:01:55 EDT

Comment on attachment 192654 [details]
the image used to illustrate the Sort Columns Actions

Patrick, please, can you commit this patch ?

Comment 22 Patrick Tessier

2011-04-07 08:31:31 EDT

Comment on attachment 192653 [details]
add user documentation for the Sort Columns actions

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 503.

Comment 23 Patrick Tessier

2011-04-07 08:31:45 EDT

Comment on attachment 192654 [details]
the image used to illustrate the Sort Columns Actions

Here is a contribution from one employee of CEA. The company has signed a Member Commiter Agreement. The contribution does not need a CQ. (http://dev.eclipse.org/mhonarc/lists/modeling-pmc/msg01997.html)
I've committed this contribution.
Committed revision 503.

Comment 24 Vincent Lorenzo

2011-04-08 08:00:48 EDT

Created attachment 192817 [details]
Add the tests for Sort Columns By Name (A To Z and Z To A)

Note : the tests are correct, and currently, they don't validate the API!

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 25 Vincent Lorenzo

2011-04-08 08:04:36 EDT

Created attachment 192818 [details]
Refactoring the ColumnComparator

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 26 Vincent Lorenzo

2011-04-08 08:06:46 EDT

Created attachment 192819 [details]
Refactoring of the ColumnComparator

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 27 Vincent Lorenzo

2011-04-08 08:08:47 EDT

Created attachment 192820 [details]
Add the tests for Sort Columns By Name (A To Z and Z To A)

Note : the tests are correct, and currently, they don't validate the API!

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.

Comment 28 Gregoire Dupe

2011-04-13 11:46:20 EDT

Hello,

The failure of the unit test org.eclipse.emf.facet.widgets.nattable.tests.NatTableAPITests.sortZToA() is caused by the bug 342603.

Regards,
Gregoire Dupe

Comment 29 Gregoire Dupe

2011-04-13 11:50:23 EDT

Comment on attachment 192819 [details]
Refactoring of the ColumnComparator

Patrick, please, can you commit this patch.

Comment 30 Gregoire Dupe

2011-04-13 11:50:56 EDT

Comment on attachment 192820 [details]
Add the tests for Sort Columns By Name (A To Z and Z To A)

Patrick, please, can you commit this patch.

Comment 31 Gregoire Dupe

2011-04-14 09:46:13 EDT

Comment on attachment 192819 [details]
Refactoring of the ColumnComparator

Here is a patch smaller than 250 lines (87 lines) this implies that no CQ is needed.

I've committed this patch.

Committed revision 516.

Comment 32 Gregoire Dupe

2011-04-14 09:53:40 EDT

Comment on attachment 192820 [details]
Add the tests for Sort Columns By Name (A To Z and Z To A)

Here is a patch smaller than 250 lines, no CQ is then needed. (64 lines)

I've committed the patch.

Committed revision 517.

Comment 33 Gregoire Dupe

2011-04-14 10:00:40 EDT

This bug has to still open until the EMF 2.7M7 release (cf. Bug 342603).

I've disable the unit test org.eclipse.emf.facet.widgets.nattable.tests.NatTableAPITests.sortZToA(). It has to be enable when EMF 2.7M7 will be available.

Regards,
Gregoire Dupe

Comment 34 Gregoire Dupe

2011-05-09 09:27:15 EDT

I've enable the "sortZToA" unit test method.

This bug can be marked as fixed.

Regards,
Gregoire Dupe

Comment 35 Vincent Lorenzo

2011-05-10 03:37:26 EDT

This bug can be marked as closed