Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 337399

Summary:

History View content should not blink

Product:

[Technology] EGit

Reporter:

Gunnar Wagenknecht <gunnar>

Component:

Assignee:

Jens Baumgart <jens.baumgart>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

markus.duft, markus.kell.r, matthias.sohn, stefan.lay

Version:

0.11

Target Milestone:

2.0-M1

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
screenshot demonstrating the issue	none

Description Gunnar Wagenknecht

2011-02-17 03:46:34 EST

Created attachment 189157 [details]
screenshot demonstrating the issue

The History View currently removes all the content and shows a text "Build commit list for ..." on a white background. This is very annoying especially when a lot resource change events are fired.

Frankly, it's not considered a good usability if a view disrupts the user experience in such a view. A recommended pattern in Eclipse UI is to use a background job for such activities and to render the view title using an italic font. The workbench does support this out-of-the box [1] and I noticed that the history view makes use of that.

If a job is already used the job should become a user job and not a system job in order to appear in the regular area. Additionally, the content flickering should be avoided and the old content should be retained delaying the view update until the last minute.


[1] http://help.eclipse.org/helios/topic/org.eclipse.platform.doc.isv/guide/workbench_jobs.htm

Comment 1 Gunnar Wagenknecht

2011-02-17 03:49:48 EST

(In reply to comment #0)
> Frankly, it's not considered a good usability if a view disrupts the user
> experience in such a view.

Sorry for the harsh statement. This really is my subjective point of view and I really should have said "I don't think it's good usability and it disrupts my user experience". I still hope that some share my view. :)

Comment 2 Stefan Lay

2011-03-04 05:33:43 EST

With commit 9c2d8a7d6b10e3e6d7270691e5d51dad811b544a there is an improvement: Now the history is only redrawn if really necessary, i.e. if either the path resulting from input and filter, the repo or the "Show all branches button" changes or if a new commit comes in.

If you for example press the "Show all changes in Repository..." button you can select any resource in the repo and nothing is redrawn.

But we still need to improve the behavior if the content is redrawn.

Comment 3 Markus Duft

2011-12-19 07:13:51 EST

for current 1.2 nightly, i observed this:

 1) select plugin - history is updated
 2) select another plugin, nothing happens (as i did select show all repo history).
 3) select "origin/master" from repo view - history is updated!
 4) select the same plugin again - history is again updated!

i think in 3 and 4 it shouldn't update, as it's the same repository, and i did the show all repo trick :)

Comment 4 Matthias Sohn

2012-03-13 19:57:13 EDT

merged as 325bde8c198119a5601bf9d9e873f59ae0b4e3c0